-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect focus styles on ActionList items #3056
Conversation
🦋 Changeset detectedLatest commit: 61123f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense to me! I am thinking if there would be any cases that cause an issue because we don't have an visual indicator for the focus state for mouse users? 🤔
I can't think of anything though but just to double check.
Great question! That is not a requirement to my knowledge. That's why the |
Sounds good to me! 🚀 |
I don't think the first item in
ActionMenu
should be focused at all by default, but this at least fixes the design bug with it. Focus styles utilize the accent blue outline, while the background is reserved for hover and active states.Closes # https://github.com/github/primer/issues/1455
Screenshots
Before:
After:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.