Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move example components to examples folder #34

Closed
wants to merge 1 commit into from
Closed

Move example components to examples folder #34

wants to merge 1 commit into from

Conversation

emplums
Copy link

@emplums emplums commented May 23, 2018

Moves all the example related components into the examples folder

For release 0.0.1: #24

@emplums emplums requested a review from shawnbot May 23, 2018 18:27
shawnbot
shawnbot previously approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have a single export from ../src (or even ../) for all of our components, but we can do that in another pass. LGTM!

@shawnbot

This comment has been minimized.

Sign in to view
@shawnbot shawnbot changed the base branch from release-0.0.1-beta to master May 25, 2018 20:19
@shawnbot shawnbot dismissed their stale review June 1, 2018 17:16

May be easier to redo than resolve conflicts?

@shawnbot
Copy link
Contributor

shawnbot commented Jun 8, 2018

This is OBE, and basically done in #61. ✌️

@shawnbot shawnbot closed this Jun 8, 2018
@shawnbot shawnbot deleted the task/move-examples branch June 8, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emplums @shawnbot