Skip to content

Docs housecleaning, etc. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 8, 2018
Merged

Docs housecleaning, etc. #61

merged 31 commits into from
Jun 8, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jun 7, 2018

Documentation updates:

  • Fix a bunch of React rendering warnings around missing key in iterators, etc.
  • Add Box examples
  • Beef up Link examples
  • Tidy up Flash and Link component JS and examples
  • Standardize example subheadings with ExampleHeading
  • Remove unused Primer CSS imports (e.g. primer-support doesn't even have CSS!)
  • Remove unused ThemeProvider from examples Page component
  • Move CSS, Meta, and Page components into examples/ (note: this causes x0 to build static HTML for each of these, which is probably not what we want!)
  • Use theme fonts and lineHeight values in the (docs) CSS component, rather than hard-coding them

Component updates

Dependency updates

  • Pin x0@5.0.4 to fix HMR issues
  • Pin styled-components@3.3.2 (it's still necessary as a dev dependency because I guess x0 or kit use it?)

Etc.

  • Ensure that classifier() doesn't duplicate class names, which should make testing easier.

@shawnbot shawnbot mentioned this pull request Jun 7, 2018
10 tasks
@shawnbot shawnbot changed the title Docs housecleaning Docs housecleaning, etc. Jun 7, 2018
@shawnbot
Copy link
Contributor Author

shawnbot commented Jun 8, 2018

One thing you'll see here is that moving the CSS, Meta, and Page components into examples/ causes static pages for them to be generated by x0. I guess that's how x0 works (edit as of version 5, it is!), so maybe the fix for #59 is to move each component <Example> into a separate file? Something to look at next week.

@shawnbot shawnbot merged commit 8174e96 into release-0.0.3-beta Jun 8, 2018
@shawnbot shawnbot deleted the docs-fixup branch June 8, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant