-
Notifications
You must be signed in to change notification settings - Fork 621
Docs housecleaning, etc. #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One thing you'll see here is that moving the CSS, Meta, and Page components into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation updates:
key
in iterators, etc.ExampleHeading
primer-support
doesn't even have CSS!)examples/
(note: this causes x0 to build static HTML for each of these, which is probably not what we want!)fonts
andlineHeight
values in the (docs) CSS component, rather than hard-coding themComponent updates
style={{...}}
) tostylizer()
inprops.js
, and use that in Block. Ref: Add Caret component #58 (comment)Dependency updates
x0@5.0.4
to fix HMR issuesstyled-components@3.3.2
(it's still necessary as a dev dependency because I guess x0 or kit use it?)Etc.
classifier()
doesn't duplicate class names, which should make testing easier.