Add a new entry point as next and update draft Tooltip to export it from next
#4250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a0faea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broccolinisoup
changed the title
next and update draft Tooltip to export it from next
size-limit report 📦
|
13 tasks
broccolinisoup
commented
Feb 12, 2024
siddharthkp
requested changes
Feb 12, 2024
joshblack
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
LGTM for the next entrypoint! 👍 Will defer to @siddharthkp's comments for stories/location 👀
broccolinisoup
force-pushed
the
next-entry-point-tooltip
branch
from
230c3a3
to
2913c16
Compare
broccolinisoup
commented
Feb 16, 2024
Merged
broccolinisoup
added a commit
that referenced
this pull request
Feb 20, 2024
… from next (#4250) * Add a new entry point as and update draft Tooltip to export it from next * fix linting n add changeset * move the src code out of drafts and update docs * fix folder path and storyname * test(vrt): update snapshots * update tooltip's position to be absolute * Update docs/content/TooltipV2.mdx --------- Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
… from next (#4250) * Add a new entry point as and update draft Tooltip to export it from next * fix linting n add changeset * move the src code out of drafts and update docs * fix folder path and storyname * test(vrt): update snapshots * update tooltip's position to be absolute * Update docs/content/TooltipV2.mdx --------- Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the Tooltip v2 adoption discussion, this PR adds a new entry point as
nextand export Tooltip from it with an updated documentation. The discussion is still open for feedback for docs consolidation, so please feel free to share any ideas/thoughts/concerns 🙌🏻Changelog
New
nextentry pointChanged
Removed
Rollout strategy
Testing & Reviewing
import {Tooltip} from '@primer/react/next'and make sure it imports the component properly.Merge checklist