Tooltip2: Prevent closing other overlays when tooltip has the focus and ESC is hit

[broccolinisoup]

Due to handling escape events in tooltip via browser (popover api), this causes an issue where tooltip is used on an element on an overlay, hitting esc key closes all overlays. Expected behaviour is that, when tooltip has the focus, hitting escape only close the tooltip.

Video previews describe the current behaviours as before and behaviour after the fix as after.

Before

tooltip-before.mp4

After

tooltip-after.mp4

Changelog

New

• Added the escape hook to take the responsibility of handling the escape events in the component rather than leaving it to the browser so that we can intercept with it and prevent escape event bubbling up.

Changed

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 797b188

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	87.82 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js	88.21 KB (+0.1% 🔺)

[siddharthkp]

Makes sense to me!

It's a little unfortunate but only because we have both portals and popovers together. I think we'll be able to remove this code once all Overlays are also dialog or popover 👍