Add support for functional color classes to color:
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/81gmex1ut |
jshorty
force-pushed
the
functional-color-classify
branch
from
2dca65d
to
fa82fd4
Compare
jshorty
force-pushed
the
functional-color-classify
branch
from
696c4e2
to
b156cff
Compare
jshorty
force-pushed
the
functional-color-classify
branch
from
b156cff
to
685e86a
Compare
jshorty
force-pushed
the
functional-color-classify
branch
from
685e86a
to
913c9ac
Compare
joelhawksley
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Thanks for the PR @jshorty! Mind adding a CHANGELOG entry?
I also wonder if we might want to update the docs for the color argument. 🤔
jshorty
commented
Feb 9, 2021
|
@jshorty no problem! ❤️ |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, color values supplied to the
color:system argument are always classified with atext-prefix (color: :my_colorbecomingtext-my-color).This breaks with new functional color classes, where in some cases, a
color-or other prefix is desired instead. This PR adds support for functional icon and text colors, a subset from the migration mapping at https://github.com/primer/css/blob/mkt/color-modes-docs/docs/content/support/v16-migration.mdx.