Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support font_size and border_radius in classify/utilities #2447

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Support font_size and border_radius in classify/utilities #2447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8904bb1
Add failing test for `font_size` and `border_radius`
kenyonj Dec 12, 2023
6a41200
Add support for `font_size` and `border_radius`
kenyonj Dec 12, 2023
b004322
Adding changeset
jonrohan Dec 12, 2023
6a441eb
Merge branch 'main' into kenyonj-patch-1
camertron Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-shoes-think.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": minor
---

Support font_size and border_radius in classify/utilities
4 changes: 3 additions & 1 deletion lib/primer/classify/utilities.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ class Utilities
"^height" => "h",
"^color-bg" => "bg",
"^color-border" => "border_color",
"^color-fg" => "color"
"^color-fg" => "color",
"^f" => "font_size",
"^rounded" => "border_radius"
}.freeze

SUPPORTED_KEY_CACHE = Hash.new { |h, k| h[k] = !UTILITIES[k].nil? }
Expand Down
1 change: 1 addition & 0 deletions test/lib/classify/utilities_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ def test_classes_to_args
assert_equal('mr: 1, mb: 2, classes: "foo"', Primer::Classify::Utilities.classes_to_args("mr-1 mb-2 foo"))
assert_equal('classes: "foo"', Primer::Classify::Utilities.classes_to_args("foo"))
assert_equal("mx: :auto", Primer::Classify::Utilities.classes_to_args("mx-auto"))
assert_equal("font_size: 3, border_radius: 0", Primer::Classify::Utilities.classes_to_args("f3 rounded-0"))
assert_equal('mr: [1, 2], classes: "baz bin"', Primer::Classify::Utilities.classes_to_args("mr-1 mr-sm-2 baz bin"))
assert_equal('mr: [1, nil, 2], classes: "foo bar"', Primer::Classify::Utilities.classes_to_args("mr-1 mr-md-2 foo bar"))
end
Expand Down
Loading