Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support font_size and border_radius in classify/utilities #2447

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

kenyonj
Copy link
Contributor

@kenyonj kenyonj commented Dec 12, 2023

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This adds support to the Primer::Classify::Utilities class for converting class names like f3 and rounded-0 to the system args/values of font_size: 3 and border_radius: 0, respectively.

Integration

I don't believe so. Was there a reason that this wasn't added that causes conflicts?

List the issues that this change affects.

Closes # #2448

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

  1. added a failing test to the utilities test file
  2. added a new entry for the REPLACEMENT_KEYS hash constant that targeted f and radius class names
  3. committed the results

Anything you want to highlight for special attention from reviewers?

Am I missing anything?

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 6a441eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kenyonj kenyonj changed the title Add failing test for font_size and border_radius Support font_size and border_radius in classify/utilities Dec 12, 2023
@kenyonj kenyonj marked this pull request as ready for review December 12, 2023 16:59
@kenyonj kenyonj requested review from a team and camertron December 12, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants