-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make docs-build action work and push to the PR branch #257
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/9LzkADDTNiGdXk3a4s8FC1FqBQCW |
Aha, protected branches are going to be a problem with this approach:
|
We could build the docs on a different branch (docs, for example) and push there? |
cc/ @manuelpuyol for thoughts? ^ |
Is it possible to commit to the branch that triggered the workflow? That way we could make it run on PRs instead of pushes on main |
We could totally do this but it means devs will need to implemented in b97c75c |
Remove empty space
@manuelpuyol ready for another 👁️ |
Follow up to #252
The previous attempt was broken. To avoid branch protection rule errors on main, now we commit the changes to the current PR branch (on push). We can choose to make this build required once we're happy with it so devs can't forget to commit the docs and also can't write broken docs.