Reduce allocations in test/performance/bench_utilities.rb

[japf]

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This PR is reducing the allocations happening in the lib/primer/classify/utilities.rb file. During performance testing, we found that the Primer::Classify::Utilities.supported_selector? method was allocating more objects than expected. We have updated the method to use the Regexp object directly instead of creating a new Regexp object each time the method is called.

Screenshots

N/A

Integration

N/A

List the issues that this change affects.

N/A

Risk Assessment

• Low risk the change is small, highly observable, and easily rolled back.
• Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
• High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

• No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Lookbook)
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: e919482

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[camertron]

Thanks for this @japf! I just merged main into your branch, which brings support for Ruby 3.3. You should be able to update the tests now.

[japf]

👋 @camertron,

I merged main again, edited the PR description and added the skip-changeset label. Please let me know if I'm missing anything.

[camertron]

Hey @japf, thanks for that! You'll also need to update the tests to reflect the new number of expected allocations.

[camertron]

Ok, it looks like the class name for the new test was BenchClassify which is the same name as another one of our perf test classes (probably a copypasta oversight). I think that was causing our tests to assert against the wrong number of allocations, depending on the order in which the test files were loaded. Hopefully this latest run works 👍

[camertron]

Huh, so weirdly if I run these new utility allocation tests multiple times, they report different numbers. We might need a warm-up or something before running them. Experimenting now.