Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release and publish scripts v2 #925

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Release and publish scripts v2 #925

merged 2 commits into from
Dec 1, 2021

Conversation

manuelpuyol
Copy link
Contributor

@manuelpuyol manuelpuyol commented Dec 1, 2021

Working with bash is not the ideal dev experience, so I'm moving our scripts to thor! Since thor scripts are written with Ruby (which most of our team is experienced with), iterating over them should be easier.

I'm also adding new features to the scripts:

  1. release will create the PR for you
  2. publish will create the release for you

Note: It's really hard to test this since I don't want to create unnecessary releases, but I'm highly confident in the code. Worst-case scenario we can fix bugs while doing the next release

@manuelpuyol manuelpuyol requested review from a team and joelhawksley December 1, 2021 18:00
@vercel
Copy link

vercel bot commented Dec 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/view-components/89o85DwJxqsBLCSBEsk192erXT6R
✅ Preview: https://view-components-git-release-publish-v2-primer.vercel.app

@manuelpuyol manuelpuyol merged commit bc7abe0 into main Dec 1, 2021
@manuelpuyol manuelpuyol deleted the release-publish-v2 branch December 1, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants