Run bundle in demo directory during release script #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will update the primer_view_components version in demo/Gemfile.lock during the release script. This wasn't working before because Thor resets the cwd between for each run command. I couldn't find a way to stop that but running it on one line works.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/view-components/6pYc8B4ZLbBVHYcYrewt8z36pNUL |
manuelpuyol
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #925, this functionality was broken because the cwd is reset between
runs. I've experienced this a few times locally and it was also flagged in #964.Can be tested locally by commenting out all the other steps in the file and running
script/release- this will update the version in Gemfile.lock to 0.0.66.