chore: toml fix #665
Merged
chore: toml fix #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
requested review from
kinrezC and
Autoparallel
and removed request for
kinrezC
Codecov Report
@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 60.73% 61.02% +0.28%
==========================================
Files 26 28 +2
Lines 5629 5616 -13
==========================================
+ Hits 3419 3427 +8
+ Misses 2210 2189 -21
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
So this throws a foundry error if we put it there. Not sure where we should put this |
|
Maybe move back to the arbiter.toml and we can put more higher level configuration there |
0xJepsen
commented
Nov 6, 2023
bin/bind/test.rs
Outdated
| @@ -0,0 +1,108 @@ | |||
| #[allow(unused_imports)] | |||
There was a problem hiding this comment.
Rename this file tests from test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646
This also takes the fork tests out of a parallel loop so they will take load off the CI and fail less frequently