Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file output type #672

Merged
merged 9 commits into from
Nov 10, 2023
Merged

file output type #672

merged 9 commits into from
Nov 10, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Nov 4, 2023

working on out putting the logs to specific file types.

This closes #671 as well as adds an option for CSV

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #672 (60a28fb) into main (31ae6e9) will increase coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 92.50%.

❗ Current head 60a28fb differs from pull request most recent head 00bb218. Consider uploading reports for the commit 00bb218 to get more accurate results

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   61.02%   61.08%   +0.06%     
==========================================
  Files          28       26       -2     
  Lines        5616     5625       +9     
==========================================
+ Hits         3427     3436       +9     
  Misses       2189     2189              
Files Coverage Δ
arbiter-core/src/data_collection.rs 91.61% <92.50%> (-1.18%) ⬇️

... and 8 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kinrezC kinrezC marked this pull request as ready for review November 4, 2023 23:39
@0xJepsen 0xJepsen self-assigned this Nov 7, 2023
@0xJepsen 0xJepsen merged commit a75739e into main Nov 10, 2023
8 of 9 checks passed
@0xJepsen 0xJepsen deleted the outputfile_optionality branch November 10, 2023 07:03
@github-actions github-actions bot mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add the ability to output to parquet files
2 participants