Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add arbiter-engine error handling #852

Merged
merged 7 commits into from
Feb 7, 2024
Merged

add arbiter-engine error handling #852

merged 7 commits into from
Feb 7, 2024

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
Give a clear and high level level overview of the tasks completed in this pull request.

Link to issue(s) that this PR closes
Closes #851

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (d0ec29a) 16.77% compared to head (2121757) 16.97%.
Report is 3 commits behind head on main.

Files Patch % Lines
arbiter-engine/src/messager.rs 60.00% 12 Missing ⚠️
arbiter-engine/src/agent.rs 73.33% 4 Missing ⚠️
arbiter-engine/src/world.rs 91.66% 3 Missing ⚠️
arbiter-macros/src/lib.rs 93.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #852      +/-   ##
==========================================
+ Coverage   16.77%   16.97%   +0.20%     
==========================================
  Files          39       41       +2     
  Lines       30124    30194      +70     
==========================================
+ Hits         5053     5126      +73     
+ Misses      25071    25068       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kinrezC kinrezC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xJepsen 0xJepsen added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit cbc87f5 Feb 7, 2024
9 of 11 checks passed
@0xJepsen 0xJepsen deleted the engine/errors branch February 7, 2024 19:32
This was referenced Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(arbiter-engine): custom errors and error handling
3 participants