Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make streams optional for behaviors for oneshot #899

Merged
merged 2 commits into from Feb 16, 2024
Merged

feat: make streams optional for behaviors for oneshot #899

merged 2 commits into from Feb 16, 2024

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
To make "oneshot" behaviors easier, we can just have startup() return an optional stream and also have a default impl for the process() method.

Link to issue(s) that this PR closes
Closes #897

kinrezC
kinrezC approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@kinrezC kinrezC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Autoparallel Autoparallel merged commit 0522476 into main Feb 16, 2024
7 of 8 checks passed
@Autoparallel Autoparallel deleted the engine/optional-stream branch February 16, 2024 19:11
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
Merged
Autoparallel added a commit that referenced this pull request Feb 29, 2024
@Autoparallel
Squashed commit of the following:
a9213c4 
commit 16bf32e
Author: Colin Roberts <colin@primitive.xyz>
Date:   Wed Feb 28 19:57:55 2024 -0700

    feat: environment logs (#911)

    * feat: logs

    * feat: filter on logs

    * refactor: `ArbiterDB` and `Environment`

commit dbca2d4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Feb 28 14:05:43 2024 -0700

    build(deps): bump crossbeam-channel from 0.5.11 to 0.5.12 (#919)

    Bumps [crossbeam-channel](https://github.com/crossbeam-rs/crossbeam) from 0.5.11 to 0.5.12.
    - [Release notes](https://github.com/crossbeam-rs/crossbeam/releases)
    - [Changelog](https://github.com/crossbeam-rs/crossbeam/blob/master/CHANGELOG.md)
    - [Commits](crossbeam-rs/crossbeam@crossbeam-channel-0.5.11...crossbeam-channel-0.5.12)

    ---
    updated-dependencies:
    - dependency-name: crossbeam-channel
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 63f167b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Feb 28 14:05:33 2024 -0700

    build(deps): bump syn from 2.0.51 to 2.0.52 (#920)

    Bumps [syn](https://github.com/dtolnay/syn) from 2.0.51 to 2.0.52.
    - [Release notes](https://github.com/dtolnay/syn/releases)
    - [Commits](dtolnay/syn@2.0.51...2.0.52)

    ---
    updated-dependencies:
    - dependency-name: syn
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit de894a3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Feb 28 14:05:20 2024 -0700

    build(deps): bump tempfile from 3.10.0 to 3.10.1 (#917)

    Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.10.0 to 3.10.1.
    - [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
    - [Commits](Stebalien/tempfile@v3.10.0...v3.10.1)

    ---
    updated-dependencies:
    - dependency-name: tempfile
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 50bfbd3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 26 13:38:48 2024 -0700

    build(deps): bump syn from 2.0.50 to 2.0.51 (#915)

    Bumps [syn](https://github.com/dtolnay/syn) from 2.0.50 to 2.0.51.
    - [Release notes](https://github.com/dtolnay/syn/releases)
    - [Commits](dtolnay/syn@2.0.50...2.0.51)

    ---
    updated-dependencies:
    - dependency-name: syn
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1db6bec
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Feb 26 10:47:13 2024 -0700

    chore: release (#914)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit 8211c6e
Author: Colin Roberts <colin@primitive.xyz>
Date:   Mon Feb 26 10:42:46 2024 -0700

    feat: `error!` output from behavior (#913)

    * feat: `error!` output from behavior
    * submodule: update `template`
    * fix: `minter` example
    * fix: clippy

commit 509b624
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Feb 21 14:50:30 2024 -0700

    chore: release (#905)

    Signed-off-by: GitHub Action <action@github.com>
    Co-authored-by: GitHub Action <action@github.com>

commit 1df12a3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Feb 20 15:55:07 2024 -0700

    build(deps): bump serde from 1.0.196 to 1.0.197 (#910)

    Bumps [serde](https://github.com/serde-rs/serde) from 1.0.196 to 1.0.197.
    - [Release notes](https://github.com/serde-rs/serde/releases)
    - [Commits](serde-rs/serde@v1.0.196...v1.0.197)

    ---
    updated-dependencies:
    - dependency-name: serde
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 875c260
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Feb 20 15:48:10 2024 -0700

    build(deps): bump syn from 2.0.49 to 2.0.50 (#908)

    Bumps [syn](https://github.com/dtolnay/syn) from 2.0.49 to 2.0.50.
    - [Release notes](https://github.com/dtolnay/syn/releases)
    - [Commits](dtolnay/syn@2.0.49...2.0.50)

    ---
    updated-dependencies:
    - dependency-name: syn
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 2d7e286
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Feb 20 15:47:57 2024 -0700

    build(deps): bump serde_json from 1.0.113 to 1.0.114 (#909)

    Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.113 to 1.0.114.
    - [Release notes](https://github.com/serde-rs/json/releases)
    - [Commits](serde-rs/json@v1.0.113...v1.0.114)

    ---
    updated-dependencies:
    - dependency-name: serde_json
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 66be5ea
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 19 20:39:07 2024 -0700

    build(deps): bump assert_cmd from 2.0.13 to 2.0.14 (#907)

    Bumps [assert_cmd](https://github.com/assert-rs/assert_cmd) from 2.0.13 to 2.0.14.
    - [Changelog](https://github.com/assert-rs/assert_cmd/blob/master/CHANGELOG.md)
    - [Commits](assert-rs/assert_cmd@v2.0.13...v2.0.14)

    ---
    updated-dependencies:
    - dependency-name: assert_cmd
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6f7f14c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 19 20:38:30 2024 -0700

    build(deps): bump anyhow from 1.0.79 to 1.0.80 (#906)

    Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.79 to 1.0.80.
    - [Release notes](https://github.com/dtolnay/anyhow/releases)
    - [Commits](dtolnay/anyhow@1.0.79...1.0.80)

    ---
    updated-dependencies:
    - dependency-name: anyhow
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 85c7987
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 16 17:54:05 2024 -0700

    build(deps): bump arbiter-engine from 0.2.0 to 0.3.0 (#902)

    Bumps [arbiter-engine](https://github.com/primitivefinance/arbiter) from 0.2.0 to 0.3.0.
    - [Release notes](https://github.com/primitivefinance/arbiter/releases)
    - [Changelog](https://github.com/primitivefinance/arbiter/blob/main/CHANGELOG.md)
    - [Commits](v0.2.0...arbiter-engine-v0.3.0)

    ---
    updated-dependencies:
    - dependency-name: arbiter-engine
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 300eaa8
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 16 17:53:46 2024 -0700

    build(deps): bump clap from 4.5.0 to 4.5.1 (#903)

    Bumps [clap](https://github.com/clap-rs/clap) from 4.5.0 to 4.5.1.
    - [Release notes](https://github.com/clap-rs/clap/releases)
    - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
    - [Commits](clap-rs/clap@clap_complete-v4.5.0...v4.5.1)

    ---
    updated-dependencies:
    - dependency-name: clap
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 1341800
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Feb 16 17:53:31 2024 -0700

    build(deps): bump syn from 2.0.48 to 2.0.49 (#901)

    Bumps [syn](https://github.com/dtolnay/syn) from 2.0.48 to 2.0.49.
    - [Release notes](https://github.com/dtolnay/syn/releases)
    - [Commits](dtolnay/syn@2.0.48...2.0.49)

    ---
    updated-dependencies:
    - dependency-name: syn
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 2913315
Author: ts0yu <120932697+ts0yu@users.noreply.github.com>
Date:   Fri Feb 16 21:04:05 2024 +0000

    docs: incorrect method (#904)

commit d768fd7
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Feb 16 12:16:33 2024 -0700

    chore: release (#896)

commit 0522476
Author: Colin Roberts <colin@primitive.xyz>
Date:   Fri Feb 16 12:11:38 2024 -0700

    feat(engine): optional stream for behaviors (#899)

    * feat: optional stream and default impl
    * test: no-stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinrezC kinrezC kinrezC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(arbiter-engine): optional stream and default process
2 participants
@Autoparallel @kinrezC