Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
balanceRisky
andbalanceStable
from Position.Data struct. This is because, ourdebt
value is also ourbalanceRisky
. AndbalanceStable
was never used. This saves 50% gas.maxPremium
parameter, which is important, because it will make sure a user does not overpay for their options, which can happen if the LP composition changes while their order is pending. The price impact check will guarantee a maxPremium to be paid, and revert otherwise.premium
to borrow. Thepremium
is the difference between the amount of lp shares borrowed, and the risky tokens released from removing liquidity.repay
.Note: State changes in these functions are critical, they should be analyzed further.