Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit/sep21 - Adds Library Fuzzing Tests for Auditors #228

Merged
merged 17 commits into from
Sep 22, 2021
Merged

Audit/sep21 - Adds Library Fuzzing Tests for Auditors #228

merged 17 commits into from
Sep 22, 2021

Conversation

Alexangelj
Copy link
Contributor

@Alexangelj Alexangelj commented Sep 22, 2021 •
edited
Loading

Changes

  • Removes Remove Callback in IPrimitiveLiquidityCallback interface. Was unused.
  • Updates natspec in CumulativeNormalDistribution.sol to include source of approximations and their absolute errors
  • Updates test contracts
  • Adds a maxError constant which is used to check the error on the solidity approximations
  • Refactors CDF test. Uses a high precision calculator to calculate a range of inputs and their outputs of the CDF and Inverse CDF. Compares this against the solidity implementations, using maxError as the error. Tests the entire domain and range.
  • Refactors Replication Math tests. Tests the entire domain and range of the replication math functions.
  • Updates various functions in the shared directory to better support decimals
  • Fixes type compilation errors in shared related files
  • Fixes failing allocate tests
  • Fixes failing create tests with tokens that dont have 18 decimals
  • Adds the poolFixture to the remaining tests to deploy tokens with different decimals, if needed
  • Adds a swap test to attempt to drain the pool by swapping an amount in, and using the amount received out in another swap.

kwisatz and others added 17 commits September 15, 2021 00:04
test(stable): stable on tests for swap
7dd3179
@Alexangelj
feat(mock-time): adds a test to mock time
d7f284c
@Alexangelj
test(cdf): adds much better cdf tests
eb630f6
@Alexangelj
feat(swap-drain): turning off invariant check can drain
c937c40
@Alexangelj
test(replication): adds some better replication tests
2f98168
@Alexangelj
test(getRisky..): adds higher fidelity tests for getRiskyGivenStable
9a15012
@Alexangelj
test(calc-inv): adds better calc invariant tests
a0c2238
@Alexangelj
test(mockTime): adds some better mock time tests
bb40ca9
@Alexangelj
feat(better-cdf): adds a more accurate cdf
e10d668
@Alexangelj
fix(testing): fixes the tests with low decimals
8dbc87c
@Alexangelj
fix(max-error): updates max error of new cdf
ad78afd
@Alexangelj
fix(engine-changes): removes engine changes for later
9356697
@Alexangelj
fix(revert-cdf): use old cdf, for now
79fd096
@Alexangelj
fix(revert-error): uses the old cdf error
8b217dc
@Alexangelj
fix(allocate-test): use reverted rather than revertedWith
fd96720
@Alexangelj
test(fix-swap): tests passing now
e4e7748
@Alexangelj
fix(remove-callback): deletes the unused remove callback
fdd4621
@Alexangelj Alexangelj merged commit c959452 into main Sep 22, 2021
@Alexangelj Alexangelj linked an issue Oct 2, 2021 that may be closed by this pull request
Dead code in interface: Remove callback #226
Closed
@Alexangelj Alexangelj deleted the audit/sep21 branch November 30, 2021 20:41
Alexangelj added a commit that referenced this pull request Mar 30, 2022
@Alexangelj
Merge pull request #228 from primitivefinance/audit/sep21
d54eb4d 
Audit/sep21 - Adds Library Fuzzing Tests for Auditors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead code in interface: Remove callback
1 participant
@Alexangelj