Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a potential error #242

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fixed a potential error #242

merged 2 commits into from
Apr 16, 2024

Conversation

DanjieTang
Copy link
Contributor

I've ran into this error several times, where it says model_patch can't be None and ending the entire program.

DanjieTang and others added 2 commits April 16, 2024 13:40
I've ran into this error several times, where it says model_patch can't be None and ending the entire program.
Copy link
Member

@klieret klieret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made it so that it doesn't even attempt to something instead. Will merge once tests pass

@klieret klieret added this to the 0.2.1 milestone Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.94%. Comparing base (3e5b4ee) to head (6f68239).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   72.94%   72.94%           
=======================================
  Files          17       17           
  Lines        2539     2539           
=======================================
  Hits         1852     1852           
  Misses        687      687           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klieret klieret merged commit 5d938f0 into princeton-nlp:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants