Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a potential error #242

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fixed a potential error #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c702fe
Fixed a potential error
DanjieTang Apr 16, 2024
6f68239
Do not attempt to save patch with empty patch
klieret Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def save_patch(traj_dir: Path, instance_id: str, info) -> Optional[Path]:
patch_output_dir = traj_dir / "patches"
patch_output_dir.mkdir(exist_ok=True, parents=True)
patch_output_file = patch_output_dir / f"{instance_id}.patch"
if not "submission" in info:
if not info.get("submission"):
logger.info("No patch to save.")
return
model_patch = info["submission"]
Expand Down
Loading