Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): disable graphql introspection in production #1170

Merged
merged 2 commits into from
Jul 3, 2020
Merged

feat(server): disable graphql introspection in production #1170

merged 2 commits into from
Jul 3, 2020

Conversation

lvauvillier
Copy link
Contributor

closes #1168

Graphql instrospection is now disabled by default in production.

A new setting can control this behavior:

settings.change({
  server: {
    graphql: {
      introspection: true
    }
  }
});

@netlify
Copy link

netlify bot commented Jul 2, 2020 •
edited

Deploy request for graphql-nexus pending review.

Review with commit 3c4989f

https://app.netlify.com/sites/graphql-nexus/deploys

@jasonkuhrt jasonkuhrt self-requested a review July 3, 2020 12:13
jasonkuhrt
jasonkuhrt approved these changes Jul 3, 2020
View reviewed changes
Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iherger!

@jasonkuhrt jasonkuhrt merged commit 54091f4 into prisma-labs:master Jul 3, 2020
@iherger
Copy link
Contributor

iherger commented Jul 3, 2020 •
edited

Thanks @iherger!

That should probably be @lvauvillier

@jasonkuhrt
Copy link
Member

Yes! Sorry @iherger 😅 Thanks @lvauvillier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonkuhrt jasonkuhrt jasonkuhrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not respond to introspection queries in production
3 participants
@lvauvillier @iherger @jasonkuhrt