fix: ignore dotfiles in watcher #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, when files in folders like `.git` and `.next` change, the reflection is ran again. The previous way of ignoring dotfiles didn't work properly.
|
Deploy request for graphql-nexus pending review. Review with commit f9040ba |
This comment has been minimized.
This comment has been minimized.
|
@jasonkuhrt what do you mean? The tests seem to pass? |
This comment has been minimized.
This comment has been minimized.
jasonkuhrt
approved these changes
Jul 7, 2020
jasonkuhrt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, when files in folders like
.gitand.nextchange, the reflection is ran again by Chokidar. The previous way of ignoring dotfiles didn't work properly.The way of ignoring dotfiles I use now is also what is mentioned in the Chokidar readme.
To reproduce this issue, clone https://github.com/SpaceK33z/graphql-nexus-watcher-issue . Start with
yarn && yarn startand modify a random file in the repo. Stage the file with git (or alternatively: trigger a git fetch). You will now see e.g.● nexus:dev:watcher restarting -- type: 'add' file: '.git/FETCH_HEAD'.closes #731