Blacklist .git/FETCH_HEAD in the watcher

[juspky]

Perceived Problem

Some Git clients like GitKraken auto refetch your repo.
This causes the watcher to randomly restart while GitKraken is open.

● nexus:dev:watcher restarting -- type: 'add' file: '.git/FETCH_HEAD'

Ideas / Proposed Solution(s)

Blacklist .git folder or possibly only .git/FETCH_HEAD if changes in .git are desired to be watched

[Weakky]

Hey 👋, thanks for reporting that bug. Unfortunately, I could not reproduce it.

The watcher should already be ignoring dot folders as you can see here https://github.com/graphql-nexus/nexus/blob/master/src/lib/watcher/watcher.ts#L91

What OS are you on?

[juspky]

This happened to me on OSX while using GitKraken

[jasonkuhrt]

@juspky are you able to reliably reproduce on your side?

[juspky]

yes I just tried it out with the latest -next release

[jasonkuhrt]

Thanks @juspky we'll try to create a repro again.

[SpaceK33z]

Hey, I created a repository to reproduce this issue; https://github.com/SpaceK33z/graphql-nexus-watcher-issue

This issue started happening when I switched to use Next.js as "server". It will also restart on all changes in the .next folder, which is quite a lot.

[jasonkuhrt]

@SpaceK33z thanks!

Realize we need another feature, which is augmenting the watcher ignore from without app settings. While plugins can do this, user should be able to drop in augment as needed. E.g. we don't have a nextjs plugin for nexus yet.

[SpaceK33z]

@jasonkuhrt thanks for your comment. I not only have it with files in .next though, but also with .git files (same as TS). From the code Weakky linked above I gather that all folders starting with a dot should be ignored and that is apparently not happening. The repo I linked above also shows how to reproduce it with .git files btw!

[SpaceK33z]

I'm pretty sure I found a fix! Pls test out #1183!