fix: postinstall false negative deps warning #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkuhrt
approved these changes
Aug 3, 2020
| // npm uses __dirname as CWD in a postinstall hook. We use INIT_CWD instead if available (set by npm) | ||
| // https://github.com/npm/npm/issues/16990#issuecomment-349731142 | ||
| const cwd = process.env.INIT_CWD || process.cwd() | ||
| const cwd = process.cwd() |
There was a problem hiding this comment.
Are we sure that process.cwd function will respect the current state of process.chdir?
There was a problem hiding this comment.
Or is the point that it doesn't and that's what we want?
Bottom line is we want this to be the project root right?
There was a problem hiding this comment.
Yes we're sure otherwise it wouldn't have fixed the deps warning!
|
Yes it works, just tried it locally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1280
TODO