Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter json doc #2314

Merged
merged 27 commits into from
Nov 24, 2021
Merged

Filter json doc #2314

merged 27 commits into from
Nov 24, 2021

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Sep 13, 2021

This PR adds missing info indicating that the filterJson feature is preview.

nilubava and others added 26 commits August 23, 2021 11:48
janpio
janpio previously requested changes Sep 13, 2021
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Using "Request changes" to block accidental merge)
Does not sound right to me. Client team will double check.

@janpio janpio self-requested a review September 13, 2021 12:39
@tanberry
Copy link
Contributor

tanberry commented Nov 9, 2021

Hi @janpio when you have a sec, can you share what you think we should do with this? Perhaps close it.. and if we still need to make any changes about implementing filterJson we can add in separate PR? Or... is that feature now GA, by some lucky chance? :-)

@janpio
Copy link
Contributor

janpio commented Nov 10, 2021

It is not GA yet unfortunately: prisma/prisma#7135

The current state of the PR looks correct to me - but I might not have the full picture. Best ask in #prisma-client so the team can let you know if this addition is indeed in the right place.

@janpio janpio removed their request for review November 10, 2021 15:58
@tanberry tanberry dismissed janpio’s stale review November 24, 2021 13:07

Client team reviewed and OK'ed.

@tanberry tanberry merged commit 098ea3c into main Nov 24, 2021
@tanberry tanberry deleted the filter-json-doc branch November 24, 2021 13:07
matthewmueller added a commit that referenced this pull request Jul 22, 2022
* fix: broken links in mdx files

* add: initial full-text search docs

* Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx

* Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx

* Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx

* Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx

* Added filterJson preview feature info

* moved preview section

Co-authored-by: Nilu <nilubava@gmail.com>
Co-authored-by: Matthew Mueller <mattmuelle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants