Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Added prisma -v to packagers #3348

Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat(cli): Added prisma -v to packagers #3348

merged 2 commits into from
Jan 5, 2023

Conversation

DavidHancu
Copy link
Contributor

This Pull Request runs prisma -v on all packagers. It is related to this Pull Request from the main repository, introducing a new feature to the prisma -v command: prisma/prisma#16874.

@janpio
Copy link
Contributor

janpio commented Jan 5, 2023

Local branch PR so that CI can run: #3349

@janpio
Copy link
Contributor

janpio commented Jan 5, 2023

This PR already uncovered a bug in how we use pnpx in the pnpm project, which @DavidHancu will open a new PR to fix:

dependencies:
+ @prisma/client 4.9.0-dev.29

devDependencies:
+ @types/node 14.18.36 (18.11.18 is available)
+ prisma 4.9.0-dev.29
+ ts-node 10.9.1
+ typescript 4.9.3 (4.9.4 is available)

Done in 12s
.../share/pnpm/store/v3/tmp/dlx-2[160](https://github.com/prisma/ecosystem-tests/actions/runs/3848508208/jobs/6556390199#step:6:161)     | Progress: resolved 1, reused 0, downloaded 0, added 0
.../share/pnpm/store/v3/tmp/dlx-2160     |   +2 +
.../node_modules/@prisma/engines postinstall$ node scripts/postinstall.js
.../share/pnpm/store/v3/tmp/dlx-2160     | Progress: resolved 2, reused 0, downloaded 2, added 2, done
.../node_modules/@prisma/engines postinstall: Done
.../prisma@4.8.0/node_modules/prisma preinstall$ node scripts/preinstall-entry.js
.../prisma@4.8.0/node_modules/prisma preinstall: Done
.../prisma@4.8.0/node_modules/prisma install$ node scripts/install-entry.js
.../prisma@4.8.0/node_modules/prisma install: Done
Prisma schema loaded from prisma/schema.prisma

✔ Generated Prisma Client (4.9.0-dev.29 | library) to ./node_modules/.pnpm/@prisma+client@4.9.0-dev.29_prisma@4.9.0-dev.29/node_modules/@prisma/client in 80ms
You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
```
import { PrismaClient } from '@prisma/client'
const prisma = new PrismaClient()
```

warn Versions of prisma@4.8.0 and @prisma/client@4.9.0-dev.29 don't match.

Note how it installs prisma 4.9.0-dev.29 but then runs with prisma@4.8.0

Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local branch showed this works

@janpio janpio merged commit 40f5c30 into prisma:dev Jan 5, 2023
@Jolg42 Jolg42 added this to the 4.9.0 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants