fix: group installs #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
reviewed
Jul 5, 2021
| await run( | ||
| 'packages/fetch-engine', | ||
| `pnpm i @prisma/get-platform@${newVersion}`, | ||
| `pnpm i @prisma/engines-version@${newVersion} @prisma/get-platform@${newVersion}`, |
There was a problem hiding this comment.
What is the benefit of doing it like this vs. how it was?
There was a problem hiding this comment.
Basically, the local package versions have already been adjusted so if you try to update the local packages individually you then run in to an issue where pnpm can not resolve one of the packages.
For example, pnpm would try to update @prisma/engines-version to (workspace:2.27.0-23.hash) but would fail as @prisma/get-platform would be pinned to (workspace:2.27.0-22.hash) but the local package has already been updated to 23 so it can't be resolved.
There was a problem hiding this comment.
I would by lying if I said I understood this, but it sounds smart so I will accept this as a great answer :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.