Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting doesn't work on Windows #27

Closed
kripod opened this issue Nov 13, 2019 · 2 comments
Closed

Code formatting doesn't work on Windows #27

kripod opened this issue Nov 13, 2019 · 2 comments
Labels
kind/feature A request for a new feature.

Comments

@kripod
Copy link

kripod commented Nov 13, 2019

When trying to auto-format a schema.prisma file from a prisma2 starter project, VS Code 1.40.0 emits the following:

image

I have the extension installed, as seen below. Am I doing something wrong?

image

Edit: It turns out that Windows is not yet supported.

@kripod kripod changed the title Code formatting doesn't work Code formatting doesn't work on Windows Nov 13, 2019
kripod added a commit to kripod/vscode-prisma that referenced this issue Nov 13, 2019
@kripod
Copy link
Author

kripod commented Nov 13, 2019

After further investigation, it turns out that a binary for Windows is available at https://s3-eu-west-1.amazonaws.com/prisma-native/alpha/latest/windows/prisma-fmt.exe.gz

I've just created a PR (#28) to add support for code formatting on Windows.

@kripod kripod mentioned this issue Nov 15, 2019
@janpio janpio added the kind/feature A request for a new feature. label Nov 21, 2019
@matthewmueller
Copy link
Contributor

Hi @kripod thanks for your help on this issue. We tested 0.0.18 and it works 😃

@matthewmueller matthewmueller removed their assignment Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants