Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for formatting files on Windows #28

Closed
wants to merge 2 commits into from
Closed

Add support for formatting files on Windows #28

wants to merge 2 commits into from

Conversation

kripod
Copy link

@kripod kripod commented Nov 13, 2019 •
edited
Loading

Resolves #27.

Tested and works with code --extensionDevelopmentPath="…" . on a prisma2 starter project.

This was referenced Nov 13, 2019
Closed
Closed
@janpio janpio added the process/candidate Candidate for next Milestone. label Nov 21, 2019
dpetrick
dpetrick suggested changes Nov 22, 2019
View reviewed changes
src/install.ts Outdated Show resolved Hide resolved
@janpio janpio added this to the Preview 18 milestone Nov 22, 2019
@janpio janpio removed the process/candidate Candidate for next Milestone. label Nov 22, 2019
@kripod kripod requested a review from dpetrick November 26, 2019 13:32
@matthewmueller
Copy link
Contributor

matthewmueller commented Dec 3, 2019 •
edited
Loading

Thanks for your PR @kripod! This should work in 0.0.16.

We ended up reusing our getPlatform() logic elsewhere in the codebase, which is more windows-friendly ☺️

https://github.com/prisma/photonjs/blob/master/packages/get-platform

@kripod
Copy link
Author

kripod commented Dec 3, 2019

@matthewmueller Unfortunately, it still doesn't work. An exe file extension should be appended for Windows, as seen here.

@matthewmueller
Copy link
Contributor

Thanks for the heads up! We just confirmed the bug and will fix this ASAP.

@matthewmueller matthewmueller reopened this Dec 4, 2019
@matthewmueller matthewmueller removed their assignment Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpetrick dpetrick Awaiting requested review from dpetrick

Assignees

@janpio janpio

@dpetrick dpetrick

Labels
None yet
Projects
None yet
Milestone
Preview 18
Development

Successfully merging this pull request may close these issues.

Code formatting doesn't work on Windows
4 participants
@kripod @matthewmueller @dpetrick @janpio