Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@prisma/language-server versions overlap for versions that are for Insider vs. stable version #868

Open
janpio opened this issue Sep 7, 2021 · 1 comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: automation topic: ci topic: internal

Comments

@janpio
Copy link
Contributor

janpio commented Sep 7, 2021

During the release process of the VSCode extension for Prisma CLI 3.0.1 workflow 3 unexpectedly crashed. Turned out there is an overlap in the versioning scheme now we start with lower minor versions again:

  • Prisma (stable) 3.0.1 (for Prisma CLI 3.0.1) => @prisma/language-server@3.0.1
  • Prisma Insider 3.0.1 (for Prisma CLI 2.3.1-dev.1) => @prisma/language-server@3.0.1 (from a looong time ago)

This leads to a crash in "3. Unit tests for LSP and publish" as the npm publish does not work.

(The overlapping version numbers "make sense" as the @prisma/language-server version is tightly coupled with the version string of the VSCode extension. We did not anticipate any problem back when we make the decision to just take both versions, both the one of the Insiders and the stable extension, and apply it to the Npm package. That was a mistake in hindsight)

Workaround

  1. Manually increase the version of packages/language-server/package.json (and package-lock.json) (e.g. +100 on the patch to make it 3.0.101)
  2. Disable workflow "6. Build Extension"
  3. Trigger "3. Unit tests for LSP and publish" again with new version 3.0.101
  4. Workflow 5 can not trigger Workflow 6 and fails
  5. Reenable workflow 6
  6. Trigger workflow 6 manually with the original version number (3.0.1) to finish the build and publish.
@janpio janpio added bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. kind/bug A reported bug. topic: automation topic: ci labels Sep 7, 2021
Jolg42 added a commit that referenced this issue Sep 21, 2021
@Jolg42 Jolg42 added this to the 3.2.0 milestone Sep 23, 2021
@Jolg42 Jolg42 self-assigned this Sep 27, 2021
@Jolg42
Copy link
Contributor

Jolg42 commented Sep 30, 2021

Added some tests in #895

Overlap happened with Prisma latest 3.0.1 & 3.1.1

Because calculated npm version is published for @prisma/language-server package see:
https://www.npmjs.com/package/@prisma/language-server?activeTab=versions

Tests here show it will be the last overlap happening for 3.x

This will repeat with 4.0 and 4.1, 5.0 and 5.1 until version 31 if nothing is done about it.
#868

@Jolg42 Jolg42 added bug/2-confirmed Bug has been reproduced and confirmed. and removed bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. labels Sep 30, 2021
@tomhoule tomhoule removed this from the 3.2.0 milestone Oct 6, 2021
@janpio janpio added the domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: automation topic: ci topic: internal
Projects
None yet
Development

No branches or pull requests

3 participants