Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech(ls): test reorg #1749

Merged
merged 6 commits into from
Jun 4, 2024
Merged

tech(ls): test reorg #1749

merged 6 commits into from
Jun 4, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jun 3, 2024

"""
Move fixtures closer to tests so it would be easier to go back and forth between them and tests
"""

takes over from #1733

@Druue @SevInf
"""
6597be2 
Move fixtures closer to tests so it would be easier to go back and forth
between them and tests
"""

takes over from #1733

Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
@Druue Druue added the kind/tech A technical change. label Jun 3, 2024
@Druue Druue added this to the 5.15.0 milestone Jun 3, 2024
@Druue Druue requested a review from SevInf June 3, 2024 14:49
@Druue Druue assigned SevInf and Druue Jun 3, 2024
@Druue Druue mentioned this pull request Jun 3, 2024
Closed
@Druue
Copy link
Contributor Author

Druue commented Jun 3, 2024

The failure comes from this line

This is from an ooold PR of yours @Jolg42. Does this make sense to update it and have it remove the new fixtures dirs in __test__ or should we remove it?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024 •
edited
Loading

🤖 Pull request artifacts

empty string

file commit
prisma.vsix faf1669

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Try this extension build via GitPod

github-actions bot added a commit that referenced this pull request Jun 3, 2024
@github-actions
Upload pull-request-artifacts/pr1749-prisma.vsix (459f3)
d00ff60 
Pull request: #1749
Commit: 459f36b
@Druue
remove fixtures from artifact
76bdef3 
test && fixture shuffle
@Druue @Jolg42
Update .github/workflows/PR_build_extension.yml
b87a60e 
Exclude whole LS __test__ dir from build extension flow

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Druue and others added 2 commits June 4, 2024 10:27
@Druue
fixture paths
8c94004
@Druue @Jolg42
Update .github/workflows/PR_build_extension.yml
faf1669 
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 4, 2024
@github-actions
Upload pull-request-artifacts/pr1749-prisma.vsix (faf16)
b376be4 
Pull request: #1749
Commit: faf1669
@Druue Druue merged commit 15e7aed into main Jun 4, 2024
7 checks passed
@Druue Druue deleted the chore/reorg-tests branch June 4, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@SevInf SevInf SevInf approved these changes

Assignees

@SevInf SevInf

@Druue Druue

Labels
kind/tech A technical change.
Projects
None yet
Milestone
5.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Druue @SevInf @Jolg42