Skip to content

Commit

Permalink
query-engine-wasm: fix build.sh with BSD sed (#4522)
Browse files Browse the repository at this point in the history
#4519 fixed the `build.sh`
script being broken with GNU sed (e.g. on Linux, including on CI) but
broke it with BSD sed (e.g. on vanilla macOS with out-of-the box BSD
sed, without GNU sed installed via Homebrew or Nix). This commit makes
the script cross-platform.

Co-authored-by: Alberto Schiabel <jkomyno@users.noreply.github.com>
  • Loading branch information
aqrln and jkomyno committed Dec 5, 2023
1 parent 79fb519 commit efb851f
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions query-engine/query-engine-wasm/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ OUT_NPM_NAME="@prisma/query-engine-wasm"
# to avoid conflicts with libquery's `name = "query_engine"` library name declaration.
# This little `sed -i` trick below is a hack to publish "@prisma/query-engine-wasm"
# with the same binding filenames currently expected by the Prisma Client.
sed -i 's/name = "query_engine_wasm"/name = "query_engine"/g' Cargo.toml
sed -i.bak 's/name = "query_engine_wasm"/name = "query_engine"/g' Cargo.toml

# use `wasm-pack build --release` on CI only
if [[ -z "$BUILDKITE" ]] && [[ -z "$GITHUB_ACTIONS" ]]; then
Expand All @@ -25,7 +25,12 @@ fi

wasm-pack build $BUILD_PROFILE --target $OUT_TARGET

sed -i 's/name = "query_engine"/name = "query_engine_wasm"/g' Cargo.toml
sed -i.bak 's/name = "query_engine"/name = "query_engine_wasm"/g' Cargo.toml

# Remove the backup file created by sed. We only created it because there's no
# cross-platform way to specify we don't need one (it's just `-i` in GNU sed
# but `-i ""` in BSD sed).
rm Cargo.toml.bak

sleep 1

Expand Down

0 comments on commit efb851f

Please sign in to comment.