query-engine-wasm: fix build.sh with BSD sed #4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4519 fixed the `build.sh` script being broken with GNU sed (e.g. on Linux, including on CI) but broke it with BSD sed (e.g. on vanilla macOS with out-of-the box BSD sed, without GNU sed installed via Homebrew or Nix). This commit makes the script cross-platform.
CodSpeed Performance ReportMerging #4522 will not alter performanceComparing Summary
|
jkomyno
added
bug/2-confirmed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4519 fixed the
build.shscript being broken with GNU sed (e.g. on Linux, including on CI) but broke it with BSD sed (e.g. on vanilla macOS with out-of-the box BSD sed, without GNU sed installed via Homebrew or Nix). This commit makes the script cross-platform.