chore: make referentialIntegrity preview feature GA #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed code - deprecated the preview feature - removed error if preview feature is missing but the datasource property is set - removed unneeded tests - updated test-api Next commit: remove all mentions of the preview feature flag
Jolg42
added a commit
to prisma/prisma
that referenced
this pull request
Nov 22, 2022
Waiting for prisma/prisma-engines#3428 to be merged first. Related #16224
Done with Tom, Thanks!
3 tasks
tomhoule
reviewed
Nov 23, 2022
Jolg42
commented
Nov 23, 2022
janpio
reviewed
Nov 24, 2022
| @@ -68,7 +68,7 @@ async fn a_table_without_uniques_should_ignore(api: &TestApi) -> TestResult { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test_connector(tags(Mysql))] | |||
| #[test_connector(tags(Mysql), exclude(Vitess))] | |||
There was a problem hiding this comment.
Why does this need to exclude Vitess now?
janpio
reviewed
Nov 24, 2022
| @@ -1,6 +1,6 @@ | |||
| use introspection_engine_tests::test_api::*; | |||
|
|
|||
| #[test_connector(tags(Mysql))] | |||
| #[test_connector(tags(Mysql), exclude(Vitess))] | |||
There was a problem hiding this comment.
Why does this need to exclude Vitess now?
janpio
reviewed
Nov 24, 2022
| @@ -3,7 +3,7 @@ use indoc::indoc; | |||
| use introspection_engine_tests::test_api::*; | |||
| use test_macros::test_connector; | |||
|
|
|||
| #[test_connector(tags(Mysql))] | |||
| #[test_connector(tags(Mysql), exclude(Vitess))] | |||
There was a problem hiding this comment.
Why does this need to exclude Vitess now?
janpio
reviewed
Nov 24, 2022
| @@ -708,7 +708,7 @@ async fn expression_indexes_should_be_ignored_on_sqlite(api: &TestApi) -> TestRe | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[test_connector(tags(Mysql))] | |||
| #[test_connector(tags(Mysql), exclude(Vitess))] | |||
There was a problem hiding this comment.
Why does this need to exclude Vitess now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related prisma/prisma#16224
Changes