feat(psl): add deprecation warning for the "referentialIntegrity" attribute #3449
Conversation
| #[test] | ||
| fn relation_mode_and_referential_integrity_cannot_cooccur() { | ||
| let schema = indoc! {r#" | ||
| datasource ps { | ||
| provider = "sqlite" | ||
| url = "sqlite" | ||
| relationMode = "prisma" | ||
| referentialIntegrity = "foreignKeys" | ||
| } | ||
| generator client { | ||
| provider = "prisma-client-js" | ||
| } | ||
| "#}; |
There was a problem hiding this comment.
Moved to relation_mode_and_referential_integrity_cannot_cooccur.prisma in the validation_tests suite
| (Some((_span, rm)), None) | (None, Some((_span, rm))) => { | ||
| let integrity = match coerce::string(rm, diagnostics)? { |
There was a problem hiding this comment.
Moved the code down here to the new get_and_validate_relation_mode_value and validate_allowed_relation_mode_settings closures, as they're used both when only the relationMode attribute is used or when only the referentialIntegrity attribute is used
There was a problem hiding this comment.
I think we are mixing concerns and making the code more complicated here. Would something much simpler like if args.contains("referentialIntegrity") { ... push the warning here ... } at the beginning of the function, before the match works. It would emit two warnings in case you defined both, but that's fine.
… when it co-occurs with the "relationMode" attribute
jkomyno
deleted the
feat/deprecation-warning-referential-integrity-attr
branch
The
referentialIntegrityattribute to set theforeignKeys|prismasettings is deprecated in favor ofrelationModeas of #3428.This PR adds a validation warning when
referentialIntegrityappears as adatasourceattribute in a Prisma schema:"""
The
referentialIntegrityattribute is deprecated. Please userelationModeinstead. Learn more at https://pris.ly/d/relation-mode"""
Closes prisma/prisma#15689.