Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not filter primary key out if having an expression index #3813

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Do not filter primary key out if having an expression index #3813

merged 2 commits into from
Mar 24, 2023

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Mar 24, 2023

@pimeys pimeys added this to the 4.12.0 milestone Mar 24, 2023
@pimeys pimeys requested a review from a team as a code owner March 24, 2023 14:56
@pimeys pimeys force-pushed the intro/mysql-expression-index-fix branch from a7ef2f4 to f063580 Compare March 24, 2023 15:01
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 24, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #3813 intro/mysql-expression-index-fix (f063580) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 6 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@pimeys pimeys merged commit 3dcc3fc into main Mar 24, 2023
@pimeys pimeys deleted the intro/mysql-expression-index-fix branch March 24, 2023 16:26
@jkomyno
Copy link
Contributor

jkomyno commented Mar 28, 2023

Any chance this PR also closes https://prisma-errors.netlify.app/report/14642?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

MySQL multi-value index removes the primary key on introspection
3 participants
@pimeys @jkomyno @tomhoule