feat(schema-engine): `CHECK` and `EXCLUDE` constraints stopgap for Postgres #3860

jkomyno · 2023-04-10T14:17:34Z

Contributes to https://github.com/prisma/schema-team/issues/384
Contributes to https://github.com/prisma/schema-team/issues/395
Contributes to Do not introspect exclusion constraints as Gist indexes prisma#17515.

Notion Details:

Note: the stopgap implementation for Check constraints is exactly the same as the one for Exclusion constraints for Postgres. Hence why they were implemented at the same time.

In terms of introspection warning codes:

CHECK: 33
EXCLUDE: 34

TODOs

add a comment at the top of the model explaining that EXCLUSION and CHECK constraints couldn't be added as they're not supported
fix Do not introspect exclusion constraints as Gist indexes prisma#17515

…ort for postgres

…exclusion constraints in postgres

schema-engine/sql-schema-describer/src/postgres/constraints_query.sql

codspeed-hq · 2023-04-10T14:32:25Z

CodSpeed Performance Report

Merging #3860 feat/postgres-check-constraints-stopgap (ea9510a) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 6 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

…onstraints when introspecting postgres

schema-engine/sql-introspection-tests/tests/postgres/mod.rs

schema-engine/connectors/sql-schema-connector/src/warnings/generators.rs

schema-engine/sql-introspection-tests/tests/postgres/mod.rs

schema-engine/connectors/sql-schema-connector/src/warnings/generators.rs

…messages

…usion constraints

…straints now adds a comment to such models

…lusion constraints

…prisma/prisma-engines into feat/postgres-check-constraints-stopgap

eviefp

This looks good to me, but I wonder if @tomhoule or anyone else could confirm that they had at least a quick look as well.

There's one nitpick comment below.

schema-engine/sql-schema-describer/src/postgres.rs

tomhoule

Nice! A few minor things but this is looking good, with the other PR that addresses the extra roundtrip (will have a look there next).

schema-engine/sql-schema-describer/src/postgres.rs

schema-engine/connectors/sql-schema-connector/src/warnings/generators.rs

schema-engine/sql-schema-describer/src/postgres.rs

…nt and ExclusionConstraint

…upsert" capabilities

* Exclude constraints are PG only, lighten up the api * Split constraint tests into its own file * Fix describer tests

schema-engine/sql-introspection-tests/tests/postgres/mod.rs

schema-engine/sql-schema-describer/src/lib.rs

pimeys · 2023-04-17T17:24:06Z

schema-engine/sql-schema-describer/src/postgres/indexes_query.sql

@@ -12,6 +12,7 @@ WITH rawindex AS (
    WHERE
        indpred IS NULL -- filter out partial indexes
        AND array_position(indkey::int2[], 0::int2) IS NULL -- filter out expression indexes
+        AND NOT indisexclusion -- filter out exclusion constraints


Could we actually do exclusions here instead?

pimeys · 2023-04-17T17:25:00Z

you also want to rebase with main to get rid of flaky vitess

janpio

Ensure this does not get merged in 4.13.0 accidentally

tomhoule · 2023-04-18T12:36:04Z

yep lots of changes since yesterday too, I'll do another review before we can merge

jkomyno · 2023-04-18T13:36:23Z

you also want to rebase with main to get rid of flaky vitess

Fyi, I have pulled main in here, but Vitess seems still flaky

tomhoule

lgtm 👍

jkomyno · 2023-04-19T11:15:39Z

Ensure this does not get merged in 4.13.0 accidentally

Could you please remove "requested changes" now? It's blocking the merge :)

asdf

jkomyno added 3 commits April 10, 2023 16:15

feat(schema-engine): add constraints_query.sql for postgres

4f9dc25

feat(schema-engine): add check and exclusion constraints stopgap supp…

70b804a

…ort for postgres

feat(schema-engine): add skeleton for stopgap warnings for check and …

10c2062

…exclusion constraints in postgres

jkomyno commented Apr 10, 2023

View reviewed changes

schema-engine/sql-schema-describer/src/postgres/constraints_query.sql Show resolved Hide resolved

feat(schema-engine): emit warnings when finding check and exclusion c…

64ae322

…onstraints when introspecting postgres

jkomyno changed the title ~~feat(schema-engine): CHECK constraints stopgap for Postgres~~ feat(schema-engine): CHECK and EXCLUDE constraints stopgap for Postgres Apr 10, 2023

jkomyno added 2 commits April 10, 2023 18:43

chore: remove comments

5e5fc2e

chore: remove dbg

993f731

janpio reviewed Apr 10, 2023

View reviewed changes

schema-engine/sql-introspection-tests/tests/postgres/mod.rs Outdated Show resolved Hide resolved

test(schema-engine): add missing defaults in describer tests

302f30e

jkomyno added this to the 4.13.0 milestone Apr 10, 2023

chore: merge main, fix conflicts

4fb955b

janpio reviewed Apr 11, 2023

View reviewed changes

schema-engine/connectors/sql-schema-connector/src/warnings/generators.rs Outdated Show resolved Hide resolved

chore: update warning messages so that they make more sense

142f618

janpio reviewed Apr 11, 2023

View reviewed changes

schema-engine/sql-introspection-tests/tests/postgres/mod.rs Outdated Show resolved Hide resolved

janpio reviewed Apr 11, 2023

View reviewed changes

schema-engine/sql-introspection-tests/tests/postgres/mod.rs Outdated Show resolved Hide resolved

Druue reviewed Apr 11, 2023

View reviewed changes

schema-engine/connectors/sql-schema-connector/src/warnings/generators.rs Outdated Show resolved Hide resolved

jkomyno added 4 commits April 12, 2023 07:28

feat(schema-engine): updated check and exclusion constraints warning …

b7b2aae

…messages

test(schema-engine): validate introspected schemas for check and excl…

4408b43

…usion constraints

feat(schema-engine): introspecting models with check or exclusion con…

aeb68b8

…straints now adds a comment to such models

feat(schema-engine): fix edge case of model having both check and exc…

19d6541

…lusion constraints

jkomyno mentioned this pull request Apr 12, 2023

feat: postgres check exclusion foreign key constraints in same query #3865

Draft

jkomyno and others added 3 commits April 12, 2023 11:03

Merge branch 'main' into feat/postgres-check-constraints-stopgap

9c5d854

feat(schema-engine): fix prisma/prisma#17515

b0d01da

Merge branch 'feat/postgres-check-constraints-stopgap' of github.com:…

24b02a9

…prisma/prisma-engines into feat/postgres-check-constraints-stopgap

eviefp approved these changes Apr 12, 2023

View reviewed changes

schema-engine/sql-schema-describer/src/postgres.rs Outdated Show resolved Hide resolved

tomhoule suggested changes Apr 13, 2023

View reviewed changes

janpio requested a review from pimeys April 14, 2023 10:21

janpio added the topic: stopgap label Apr 14, 2023

jkomyno added 3 commits April 17, 2023 00:34

chore: remove dead code

df347af

chore: fix conflicts

e936a8b

fix: avoid duplicated model commments upon reintrospection

2c6e879

prisma deleted a comment from sonatype-lift bot Apr 16, 2023

jkomyno added 2 commits April 17, 2023 12:21

feat(schema-engine): use ModelAndConstraint rather than CheckConstrai…

51f06d9

…nt and ExclusionConstraint

feat(schema-engine): replace IndexMap with BTreeMap for leaner flag "…

3c74298

…upsert" capabilities

jkomyno mentioned this pull request Apr 17, 2023

integration: postgres check constraints stopgap #3886

Closed

chore: add TODO to answer Tom's review comment

e5a6d89

tomhoule approved these changes Apr 17, 2023

View reviewed changes

jkomyno and others added 2 commits April 17, 2023 16:12

Merge branch 'main' into feat/postgres-check-constraints-stopgap

99045f1

Exclude constraints are PG only, lighten up the api (#3887)

b9af982

* Exclude constraints are PG only, lighten up the api * Split constraint tests into its own file * Fix describer tests

pimeys reviewed Apr 17, 2023

View reviewed changes

Merge branch 'main' into feat/postgres-check-constraints-stopgap

e79ebe6

janpio modified the milestones: 4.13.0, 4.14.0 Apr 18, 2023

janpio previously requested changes Apr 18, 2023

View reviewed changes

feat(schema-engine): apply review comments

4362401

jkomyno requested review from tomhoule and pimeys April 18, 2023 15:57

janpio self-requested a review April 18, 2023 19:02

pimeys approved these changes Apr 19, 2023

View reviewed changes

tomhoule approved these changes Apr 19, 2023

View reviewed changes

Merge branch 'main' into feat/postgres-check-constraints-stopgap

ea9510a

jkomyno merged commit 42f41a6 into main Apr 19, 2023
49 checks passed

jkomyno deleted the feat/postgres-check-constraints-stopgap branch April 19, 2023 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(schema-engine): `CHECK` and `EXCLUDE` constraints stopgap for Postgres #3860

feat(schema-engine): `CHECK` and `EXCLUDE` constraints stopgap for Postgres #3860

jkomyno commented Apr 10, 2023 •

edited by Druue

Loading

codspeed-hq bot commented Apr 10, 2023 •

edited

Loading

eviefp left a comment

tomhoule left a comment

pimeys Apr 17, 2023

pimeys commented Apr 17, 2023

janpio left a comment

tomhoule commented Apr 18, 2023

jkomyno commented Apr 18, 2023

tomhoule left a comment

jkomyno commented Apr 19, 2023

feat(schema-engine): CHECK and EXCLUDE constraints stopgap for Postgres #3860

feat(schema-engine): CHECK and EXCLUDE constraints stopgap for Postgres #3860

Conversation

jkomyno commented Apr 10, 2023 • edited by Druue Loading

TODOs

codspeed-hq bot commented Apr 10, 2023 • edited Loading

CodSpeed Performance Report

Summary

eviefp left a comment

Choose a reason for hiding this comment

tomhoule left a comment

Choose a reason for hiding this comment

pimeys Apr 17, 2023

Choose a reason for hiding this comment

pimeys commented Apr 17, 2023

janpio left a comment

Choose a reason for hiding this comment

tomhoule commented Apr 18, 2023

jkomyno commented Apr 18, 2023

tomhoule left a comment

Choose a reason for hiding this comment

jkomyno commented Apr 19, 2023

feat(schema-engine): `CHECK` and `EXCLUDE` constraints stopgap for Postgres #3860

feat(schema-engine): `CHECK` and `EXCLUDE` constraints stopgap for Postgres #3860

jkomyno commented Apr 10, 2023 •

edited by Druue

Loading

codspeed-hq bot commented Apr 10, 2023 •

edited

Loading