Exclude constraints are PG only, lighten up the api #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
alberto/constraint-fixes
branch
from
1311064
to
214d031
Compare
CodSpeed Performance ReportMerging #3887 Summary
|
jkomyno
added a commit
that referenced
this pull request
Apr 19, 2023
…stgres (#3860) * feat(schema-engine): add constraints_query.sql for postgres * feat(schema-engine): add check and exclusion constraints stopgap support for postgres * feat(schema-engine): add skeleton for stopgap warnings for check and exclusion constraints in postgres * feat(schema-engine): emit warnings when finding check and exclusion constraints when introspecting postgres * chore: remove comments * chore: remove dbg * test(schema-engine): add missing defaults in describer tests * chore: update warning messages so that they make more sense * feat(schema-engine): updated check and exclusion constraints warning messages * test(schema-engine): validate introspected schemas for check and exclusion constraints * feat(schema-engine): introspecting models with check or exclusion constraints now adds a comment to such models * feat(schema-engine): fix edge case of model having both check and exclusion constraints * feat(schema-engine): fix prisma/prisma#17515 * chore: remove dead code * chore: fix conflicts * fix: avoid duplicated model commments upon reintrospection * feat(schema-engine): use ModelAndConstraint rather than CheckConstraint and ExclusionConstraint * feat(schema-engine): replace IndexMap with BTreeMap for leaner flag "upsert" capabilities * chore: add TODO to answer Tom's review comment * Exclude constraints are PG only, lighten up the api (#3887) * Exclude constraints are PG only, lighten up the api * Split constraint tests into its own file * Fix describer tests * feat(schema-engine): apply review comments --------- Co-authored-by: Julius de Bruijn <julius+github@nauk.io>
jkomyno
reviewed
Apr 19, 2023
Comment on lines
+126
to
+133
| /// The check constraint names for the table. | ||
| pub fn check_constraints(self) -> impl ExactSizeIterator<Item = &'a str> { | ||
| let low = self.schema.check_constraints.partition_point(|(id, _)| *id < self.id); | ||
| let high = self.schema.check_constraints[low..].partition_point(|(id, _)| *id <= self.id); | ||
|
|
||
| self.schema.check_constraints[low..high] | ||
| .iter() | ||
| .map(|(_, name)| name.as_str()) |
There was a problem hiding this comment.
Note: this has caused dramatic issues in introspection-ci.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we do here: