Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver-adapters: fix Transaction.dispose for pg and neon #4295

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Sep 27, 2023

Fixes https://github.com/prisma/team-orm/issues/390

See also https://github.com/prisma/team-orm/issues/391 for a suggestion to prevent this class of issues

@aqrln aqrln requested a review from a team as a code owner September 27, 2023 19:35
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2023

CodSpeed Performance Report

Merging #4295 will not alter performance

Comparing fix-pg-transaction (ced7a45) with main (e3ff754)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln added this to the 5.4.0 milestone Sep 27, 2023
@aqrln aqrln added the topic: driver adapters formerly phase 1 label Sep 27, 2023
@aqrln
Copy link
Member Author

aqrln commented Sep 27, 2023

Confirmed by Pierre that it fixes the issue.

@aqrln aqrln merged commit 743c426 into main Sep 27, 2023
31 of 38 checks passed
@aqrln aqrln deleted the fix-pg-transaction branch September 27, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: driver adapters formerly phase 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant