Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver-adapters): rename "flavour" into "provider" #4512

Merged
merged 3 commits into from
Dec 1, 2023
Merged

feat(driver-adapters): rename "flavour" into "provider" #4512

merged 3 commits into from
Dec 1, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 1, 2023

This PR subsumes #4511.
This PR contributes to prisma/prisma#21865.

/integration

@jkomyno jkomyno mentioned this pull request Dec 1, 2023
Closed
SevInf
SevInf approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 optional suggestion

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 1, 2023 •
edited

CodSpeed Performance Report

Merging #4512 will improve performances by 5.77%

Comparing feat/driver-adapters-public-api-provider (89eaa48) with main (f2e5886)

Summary

⚡ 1 improvements
✅ 10 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/driver-adapters-public-api-provider Change
⚡ large_read 7.6 ms 7.2 ms +5.77%

@jkomyno jkomyno added this to the 5.7.0 milestone Dec 1, 2023
@jkomyno @SevInf
feat(driver-adapters): fallback to \"flavour\" for prisma@5.7.0
6add207 
Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
@jkomyno jkomyno marked this pull request as ready for review December 1, 2023 11:47
@jkomyno jkomyno requested a review from a team as a code owner December 1, 2023 11:47
@jkomyno jkomyno requested review from miguelff and Druue and removed request for a team December 1, 2023 11:47
@jkomyno jkomyno self-assigned this Dec 1, 2023
@jkomyno jkomyno merged commit f0e6ac4 into main Dec 1, 2023
35 checks passed
@jkomyno jkomyno deleted the feat/driver-adapters-public-api-provider branch December 1, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@miguelff miguelff Awaiting requested review from miguelff miguelff is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees

@jkomyno jkomyno

Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkomyno @SevInf