Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(driver adapters): [public API] Rename flavour field to provider #4511

Closed

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 30, 2023

This PR contributes to prisma/prisma#21865.

/integration


TODO: test with prisma/prisma#21891? cc @SevInf

@jkomyno jkomyno changed the base branch from main to tmp/vertical-slice-ci-test November 30, 2023 22:57
Copy link

codspeed-hq bot commented Nov 30, 2023

CodSpeed Performance Report

Merging #4511 will not alter performance

Comparing feat/driver-adapters-public-api (0f30392) with tmp/vertical-slice-ci-test (0cd2541)

Summary

✅ 11 untouched benchmarks

@jkomyno
Copy link
Contributor Author

jkomyno commented Dec 1, 2023

Deprecated by #4512.

@jkomyno jkomyno closed this Dec 1, 2023
jkomyno added a commit to prisma/prisma that referenced this pull request Dec 4, 2023
…er`, remove `close()` (#22179)

* chore(driver-adapters): rename "flavour" to "provider"

* chore(driver-adapters): update wasm to point to prisma/prisma-engines#4511

* feat(driver-adapters): remove "close()" from the public "DriverAdapters" interface

* feat(driver-adapters): turn "close()" into optional

* chore(driver-adapters): fixed typo

* Revert "feat(driver-adapters): turn "close()" into optional"

This reverts commit 94df8c7.

* chore(driver-adapters): remove "close()" from "@prisma/adapter-libsql"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant