Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v5.4.3 #4800

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 30, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) 5.4.2 -> 5.4.3 age adoption passing confidence

Release Notes

Microsoft/TypeScript (typescript)

v5.4.3: TypeScript 5.4.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 30, 2024 02:05
@renovate renovate bot requested review from Weakky and removed request for a team March 30, 2024 02:05
Copy link
Contributor

github-actions bot commented Mar 30, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.079MiB 2.079MiB 0.000B
Postgres (gzip) 821.401KiB 821.407KiB -6.000B
Mysql 2.050MiB 2.050MiB 0.000B
Mysql (gzip) 808.540KiB 808.542KiB -3.000B
Sqlite 1.945MiB 1.945MiB 0.000B
Sqlite (gzip) 769.426KiB 769.427KiB -1.000B

Copy link

codspeed-hq bot commented Mar 30, 2024

CodSpeed Performance Report

Merging #4800 will not alter performance

⚠️ No base runs were found

Falling back to comparing renovate/typescript-5.4.x (93d56e7) with main (473ed31)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

✅ WASM query-engine performance won't change substantially (1.006x)

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
"
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.19.1 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p999
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - ~50K)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     362 ms/iter       (359 ms … 368 ms)    364 ms    368 ms    368 ms
Web Assembly: Latest       442 ms/iter       (441 ms … 444 ms)    443 ms    444 ms    444 ms
Web Assembly: Current      445 ms/iter       (444 ms … 446 ms)    446 ms    446 ms    446 ms
Node API: Current          200 ms/iter       (195 ms … 211 ms)    210 ms    211 ms    211 ms

summary for movies.findMany() (all - ~50K)
  Web Assembly: Current
   2.22x slower than Node API: Current
   1.23x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  14'585 µs/iter (14'416 µs … 16'524 µs) 14'523 µs 16'524 µs 16'524 µs
Web Assembly: Latest    18'186 µs/iter (17'622 µs … 21'042 µs) 18'126 µs 21'042 µs 21'042 µs
Web Assembly: Current   18'159 µs/iter (18'048 µs … 18'429 µs) 18'210 µs 18'429 µs 18'429 µs
Node API: Current        8'022 µs/iter   (7'921 µs … 8'286 µs)  8'054 µs  8'286 µs  8'286 µs

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   2.26x slower than Node API: Current
   1.25x slower than Web Assembly: Baseline
   1x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   2'292 µs/iter   (2'178 µs … 3'522 µs)  2'280 µs  3'253 µs  3'522 µs
Web Assembly: Latest     2'805 µs/iter   (2'725 µs … 3'543 µs)  2'805 µs  3'407 µs  3'543 µs
Web Assembly: Current    2'851 µs/iter   (2'747 µs … 4'280 µs)  2'832 µs  3'619 µs  4'280 µs
Node API: Current        1'379 µs/iter   (1'299 µs … 1'878 µs)  1'397 µs  1'606 µs  1'878 µs

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   2.07x slower than Node API: Current
   1.24x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     560 ms/iter       (557 ms … 566 ms)    562 ms    566 ms    566 ms
Web Assembly: Latest       738 ms/iter       (734 ms … 750 ms)    745 ms    750 ms    750 ms
Web Assembly: Current      753 ms/iter       (747 ms … 763 ms)    763 ms    763 ms    763 ms
Node API: Current          460 ms/iter       (454 ms … 471 ms)    464 ms    471 ms    471 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.64x slower than Node API: Current
   1.34x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  78'550 µs/iter (78'151 µs … 79'885 µs) 78'843 µs 79'885 µs 79'885 µs
Web Assembly: Latest       104 ms/iter       (103 ms … 107 ms)    105 ms    107 ms    107 ms
Web Assembly: Current      106 ms/iter       (105 ms … 110 ms)    106 ms    110 ms    110 ms
Node API: Current       59'436 µs/iter (58'908 µs … 60'005 µs) 59'580 µs 60'005 µs 60'005 µs

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.79x slower than Node API: Current
   1.35x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     996 ms/iter     (993 ms … 1'006 ms)  1'001 ms  1'006 ms  1'006 ms
Web Assembly: Latest     1'238 ms/iter   (1'231 ms … 1'248 ms)  1'247 ms  1'248 ms  1'248 ms
Web Assembly: Current    1'245 ms/iter   (1'240 ms … 1'256 ms)  1'254 ms  1'256 ms  1'256 ms
Node API: Current          850 ms/iter       (817 ms … 876 ms)    872 ms    876 ms    876 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.47x slower than Node API: Current
   1.25x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline     140 ms/iter       (140 ms … 141 ms)    141 ms    141 ms    141 ms
Web Assembly: Latest       172 ms/iter       (172 ms … 173 ms)    172 ms    173 ms    173 ms
Web Assembly: Current      174 ms/iter       (173 ms … 174 ms)    174 ms    174 ms    174 ms
Node API: Current          103 ms/iter       (102 ms … 104 ms)    104 ms    104 ms    104 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.69x slower than Node API: Current
   1.24x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'036 µs/iter     (973 µs … 1'717 µs)  1'033 µs  1'631 µs  1'717 µs
Web Assembly: Latest     1'360 µs/iter   (1'289 µs … 1'933 µs)  1'358 µs  1'786 µs  1'933 µs
Web Assembly: Current    1'377 µs/iter   (1'304 µs … 2'011 µs)  1'373 µs  1'863 µs  2'011 µs
Node API: Current          755 µs/iter       (704 µs … 978 µs)    777 µs    830 µs    978 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.82x slower than Node API: Current
   1.33x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   1'018 µs/iter     (978 µs … 1'690 µs)  1'025 µs  1'324 µs  1'690 µs
Web Assembly: Latest     1'405 µs/iter   (1'290 µs … 2'557 µs)  1'360 µs  2'512 µs  2'557 µs
Web Assembly: Current    1'355 µs/iter   (1'299 µs … 1'978 µs)  1'360 µs  1'688 µs  1'978 µs
Node API: Current          784 µs/iter       (752 µs … 983 µs)    796 µs    837 µs    983 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.73x slower than Node API: Current
   1.33x slower than Web Assembly: Baseline
   1.04x faster than Web Assembly: Latest

After changes in 37244dc

@renovate renovate bot force-pushed the renovate/typescript-5.4.x branch from 37244dc to 93d56e7 Compare April 3, 2024 06:34
@Jolg42 Jolg42 added this to the 5.13.0 milestone Apr 3, 2024
@Jolg42 Jolg42 merged commit d5a80e2 into main Apr 3, 2024
173 of 181 checks passed
@Jolg42 Jolg42 deleted the renovate/typescript-5.4.x branch April 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant