Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prisma/prisma#23902 #4832

Closed
wants to merge 1 commit into from
Closed

fix prisma/prisma#23902 #4832

wants to merge 1 commit into from

Conversation

hrueger
Copy link

@hrueger hrueger commented Apr 20, 2024

Hi all,
this should fix prisma/prisma#23902. As the rows_written return field by D1 includes writes to index tables, the number of rows_written might be greater than the expected count.

It would of course be better to either
a) get the index fields in this context and calculate the expected number of writes differently for D1 or
b) only apply that fix if the D1 adapter is used.

Unfortunately, I'm not familiar enough with Rust to do either of those.

Thanks for looking into this!

@hrueger hrueger requested a review from a team as a code owner April 20, 2024 08:13
@hrueger hrueger requested review from Weakky and removed request for a team April 20, 2024 08:13
@CLAassistant
Copy link

CLAassistant commented Apr 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Apr 22, 2024

CodSpeed Performance Report

Merging #4832 will not alter performance

Comparing hrueger:main (5d6a692) with main (3364458)

Summary

✅ 11 untouched benchmarks

@Jolg42
Copy link
Contributor

Jolg42 commented May 6, 2024

Thanks, though I think we can actually switch to a better count, changes instead, see prisma/prisma#24083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants