refactor: drop support for Node.js 10 (#7573)

prisma · Jun 10, 2021 · 2680a44 · 2680a44
1 parent c960ec1
commit 2680a44
Show file tree

Hide file tree

Showing 11 changed files with 4,379 additions and 3,761 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/packages/cli/README.md b/src/packages/cli/README.md
@@ -8,7 +8,7 @@ Check out the [**Getting Started Quickstart**](https://www.prisma.io/docs/gettin
 
 ## Installation
 
-The Prisma CLI currently requires Node.js 10.4 (or higher).
+The Prisma CLI currently requires Node.js 12.2 (or higher).
 We recommend using [the latest Node.js LTS ("long-term support") release.](https://nodejs.org/en/about/releases/)
 
 ### npm

diff --git a/src/packages/cli/helpers/build.js b/src/packages/cli/helpers/build.js
@@ -23,7 +23,7 @@ async function main() {
     esbuild.build({
       platform: 'node',
       bundle: true,
-      target: 'node10',
+      target: 'node12',
       outfile: 'build/index.js',
       entryPoints: ['src/bin.ts'],
       external: ['@prisma/engines', '_http_common'],
@@ -32,15 +32,15 @@ async function main() {
       platform: 'node',
       bundle: true,
       minify: true,
-      target: ['node10'],
+      target: ['node12'],
       outfile: 'preinstall/index.js',
       entryPoints: ['scripts/preinstall.js'],
     }),
     esbuild.build({
       platform: 'node',
       bundle: true,
       minify: true,
-      target: ['node10'],
+      target: ['node12'],
       outfile: 'install/index.js',
       entryPoints: ['scripts/install.js'],
     }),

diff --git a/src/packages/cli/package.json b/src/packages/cli/package.json
@@ -29,7 +29,7 @@
   "bugs": "https://github.com/prisma/prisma/issues",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=10.4"
+    "node": ">=12.2"
   },
   "prisma": {
     "prismaCommit": "placeholder-for-commit-hash-replaced-during-publishing-in-publish-ts"

diff --git a/src/packages/cli/scripts/preinstall.js b/src/packages/cli/scripts/preinstall.js
@@ -118,10 +118,11 @@ export function main() {
 
   const nodeVersions = process.version.split('.')
   const nodeMajorVersion = parseInt(nodeVersions[0].slice(1))
-  if (nodeMajorVersion < 10) {
+  const nodeMinorVersion = parseInt(nodeVersions[1])
+  if (nodeMajorVersion < 12 || (nodeMajorVersion === 12 && nodeMinorVersion < 2)) {
     console.error(
       drawBox({
-        str: `Prisma only supports Node.js >= 10`,
+        str: `Prisma only supports Node.js >= 12.2`,
         verticalPadding: 1,
         horizontalPadding: 3,
       }),

diff --git a/src/packages/client/helpers/build.js b/src/packages/client/helpers/build.js
@@ -28,7 +28,7 @@ async function main() {
     esbuild.build({
       platform: 'node',
       bundle: true,
-      target: 'node10',
+      target: 'node12',
       outfile: 'generator-build/index.js',
       entryPoints: ['src/generator.ts'],
       external: ['_http_common']
@@ -39,7 +39,7 @@ async function main() {
     esbuild.build({
       platform: 'node',
       bundle: true,
-      target: 'node10',
+      target: 'node12',
       outdir: 'runtime',
       entryPoints: ['src/runtime/index.ts'],
       external: ['_http_common']

diff --git a/src/packages/client/package.json b/src/packages/client/package.json
@@ -24,7 +24,7 @@
   "types": "index.d.ts",
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=10.16"
+    "node": ">=12.2"
   },
   "homepage": "https://www.prisma.io",
   "repository": "git@github.com:prisma/prisma.git",

diff --git a/src/packages/client/src/__tests__/integration/happy/float-napi/dev.db b/src/packages/client/src/__tests__/integration/happy/float-napi/dev.db
diff --git a/src/packages/client/src/__tests__/integration/happy/middlewares/dev.db b/src/packages/client/src/__tests__/integration/happy/middlewares/dev.db
diff --git a/src/packages/client/src/runtime/query.ts b/src/packages/client/src/runtime/query.ts
@@ -1472,19 +1472,7 @@ function valueToArg(key: string, value: any, arg: DMMF.SchemaArg): Arg | null {
       }
     })
 
-    // because Node 10's sort has a different order for sorting than Node 11+
-    let scoresEqual = true
-    const currentScore = argsWithScores[0].score
-    for (const { score } of argsWithScores) {
-      if (score !== currentScore) {
-        scoresEqual = false
-        break
-      }
-    }
-
-    if (!scoresEqual) {
-      argsWithScores.sort((a, b) => (a.score < b.score ? -1 : 1))
-    }
+    argsWithScores.sort((a, b) => (a.score < b.score ? -1 : 1))
 
     return argsWithScores[0].arg
   }