chore: change all packages to strict (#5114)

src/packages/fetch-engine/package.json

@@ -11,6 +11,7 @@
     "@types/node": "12.19.13",
     "@types/node-fetch": "2.5.7",
     "@types/progress": "2.0.3",
+    "@types/find-cache-dir": "^3.2.0",
     "@typescript-eslint/eslint-plugin": "4.13.0",
     "@typescript-eslint/parser": "4.13.0",
     "del": "6.0.0",

src/packages/fetch-engine/src/__tests__/download.test.ts

@@ -193,7 +193,7 @@ describe('download', () => {
         'query-engine': __dirname,
       },
     })
-    const dummyPath = e['query-engine'][Object.keys(e['query-engine'])[0]]!
+    const dummyPath = e['query-engine']![Object.keys(e['query-engine']!)[0]]!
     const targetPath = path.join(
       __dirname,
       getBinaryName('query-engine', 'marvin'),
@@ -207,7 +207,7 @@ describe('download', () => {
       },
       binaryTargets: ['marvin'] as any, // eslint-disable-line @typescript-eslint/no-explicit-any
     })
-    expect(testResult['query-engine']['marvin']).toEqual(targetPath)
+    expect(testResult['query-engine']!['marvin']).toEqual(targetPath)
   })
   test.skip('download all binaries & cache them', async () => {
     const baseDir = path.join(__dirname, 'all')

src/packages/fetch-engine/src/cleanupCache.ts

@@ -4,15 +4,20 @@ import { getRootCacheDir } from './util'
 import rimraf from 'rimraf'
 import { promisify } from 'util'
 import pMap from 'p-map'
-// import Debug from '@prisma/debug'
-// const debug = Debug('cleanupCache')
+
+import Debug from '@prisma/debug'
+const debug = Debug('cleanupCache')
 const del = promisify(rimraf)
 const readdir = promisify(fs.readdir)
 const stat = promisify(fs.stat)
 
 export async function cleanupCache(n = 5): Promise<void> {
   try {
     const rootCacheDir = await getRootCacheDir()
+    if(!rootCacheDir){
+      debug('no rootCacheDir found')
+      return
+    }
     const channel = 'master'
     const cacheDir = path.join(rootCacheDir, channel)
     const dirs = await readdir(cacheDir)

src/packages/fetch-engine/src/download.ts

@@ -67,15 +67,15 @@ type BinaryDownloadJob = {
   binaryTarget: string
   fileName: string
   targetFilePath: string
-  envVarPath: string
+  envVarPath: string | null
 }
 
 export async function download(options: DownloadOptions): Promise<BinaryPaths> {
   // get platform
   const platform = await getPlatform()
   const os = await getos()
 
-  if (['nixos'].includes(os.distro)) {
+  if (os.distro && ['nixos'].includes(os.distro)) {
     console.error(
       `${chalk.yellow('Warning')} Precompiled binaries are not available for ${
         os.distro
@@ -97,19 +97,18 @@ export async function download(options: DownloadOptions): Promise<BinaryPaths> {
   }
 
   // merge options
-  options = {
+  const opts = {
     ...options,
     binaryTargets: options.binaryTargets ?? [platform],
     version: options.version ?? 'latest',
-    binaries: mapKeys(options.binaries, (key) =>
-      engineTypeToBinaryType(key, platform),
+    binaries: mapKeys(options.binaries, (key) => engineTypeToBinaryType(key, platform),
     ), // just necessary to support both camelCase and hyphen-case
   }
 
-  const binaryJobs: Array<BinaryDownloadJob> = flatMap(
-    Object.entries(options.binaries),
-    ([binaryName, targetFolder]) =>
-      options.binaryTargets.map((binaryTarget) => {
+  const binaryJobs = flatMap(
+    Object.entries(opts.binaries),
+    ([binaryName, targetFolder]: [string, string]) =>
+      opts.binaryTargets.map((binaryTarget) => {
         const fileName = getBinaryName(binaryName, binaryTarget)
         return {
           binaryName,
@@ -123,30 +122,30 @@ export async function download(options: DownloadOptions): Promise<BinaryPaths> {
   )
 
   if (process.env.BINARY_DOWNLOAD_VERSION) {
-    options.version = process.env.BINARY_DOWNLOAD_VERSION
+    opts.version = process.env.BINARY_DOWNLOAD_VERSION
   }
 
-  if (options.version === 'latest') {
-    options.version = await getLatestTag()
+  if (opts.version === 'latest') {
+    opts.version = await getLatestTag()
   }
 
-  if (options.printVersion) {
-    console.log(`version: ${options.version}`)
+  if (opts.printVersion) {
+    console.log(`version: ${opts.version}`)
   }
 
   // filter out files, which don't yet exist or have to be created
   const binariesToDownload = await pFilter(binaryJobs, async (job) => {
     const needsToBeDownloaded = await binaryNeedsToBeDownloaded(
       job,
       platform,
-      options.version,
-      options.failSilent,
+      opts.version,
+      opts.failSilent,
     )
     const isSupported = platforms.includes(job.binaryTarget as Platform)
     const shouldDownload =
       isSupported &&
       !job.envVarPath &&
-      (options.ignoreCache || needsToBeDownloaded)
+      (opts.ignoreCache || needsToBeDownloaded)
     if (needsToBeDownloaded && !isSupported) {
       throw new Error(
         `Unknown binaryTarget ${job.binaryTarget} and no custom binaries were provided`,
@@ -163,8 +162,8 @@ export async function download(options: DownloadOptions): Promise<BinaryPaths> {
       | undefined
       | ((sourcePath: string) => (progress: number) => void)
 
-    if (options.showProgress) {
-      const collectiveBar = getCollectiveBar(options)
+    if (opts.showProgress) {
+      const collectiveBar = getCollectiveBar(opts)
       finishBar = collectiveBar.finishBar
       setProgress = collectiveBar.setProgress
     }
@@ -174,8 +173,8 @@ export async function download(options: DownloadOptions): Promise<BinaryPaths> {
       binariesToDownload.map((job) =>
         downloadBinary({
           ...job,
-          version: options.version,
-          failSilent: options.failSilent,
+          version: opts.version,
+          failSilent: opts.failSilent,
           progressCb: setProgress ? setProgress(job.targetFilePath) : undefined,
         }),
       ),
@@ -212,15 +211,15 @@ function getCollectiveBar(
 } {
   const bar = getBar(
     `Downloading Prisma engines for ${options.binaryTargets
-      .map((p) => chalk.bold(p))
+      ?.map((p) => chalk.bold(p))
       .join(' and ')}`,
   )
 
   const progressMap: { [key: string]: number } = {}
   // Object.values is faster than Object.keys
   const numDownloads =
     Object.values(options.binaries).length *
-    Object.values(options.binaryTargets).length
+    Object.values(options?.binaryTargets ?? []).length
   const setProgress = (sourcePath: string) => (progress): void => {
     progressMap[sourcePath] = progress
     const progressValues = Object.values(progressMap)
@@ -262,7 +261,7 @@ async function binaryNeedsToBeDownloaded(
   job: BinaryDownloadJob,
   nativePlatform: string,
   version: string,
-  failSilent: boolean,
+  failSilent?: boolean,
 ): Promise<boolean> {
   const binaryPath = job.envVarPath ?? job.targetFilePath
 
@@ -337,7 +336,7 @@ export function getBinaryName(binaryName: string, platform: string): string {
 
 type GetCachedBinaryOptions = BinaryDownloadJob & {
   version: string
-  failSilent: boolean
+  failSilent?: boolean
 }
 
 async function getCachedBinaryPath({
@@ -372,7 +371,7 @@ async function getCachedBinaryPath({
 export function getBinaryEnvVarPath(binaryName: string): string | null {
   const envVar = binaryToEnvVar[binaryName]
   if (envVar && process.env[envVar]) {
-    const envVarPath = path.resolve(process.cwd(), process.env[envVar])
+    const envVarPath = path.resolve(process.cwd(), process.env[envVar] as string)
     if (!fs.existsSync(envVarPath)) {
       throw new Error(
         `Env var ${chalk.bold(
@@ -508,15 +507,15 @@ function engineTypeToBinaryType(
   return engineType
 }
 
-function mapKeys<T extends object>(
+function mapKeys<T extends object, K extends keyof T>(
   obj: T,
-  mapper: (key: keyof T) => string,
+  mapper: (key: K) => string,
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-): any {
+) {
   return Object.entries(obj).reduce((acc, [key, value]) => {
-    acc[mapper(key as keyof T)] = value
+    acc[mapper(key as K)] = value
     return acc
-  }, {})
+  }, {} as Record<string, any>)
 }
 
 export async function maybeCopyToTmp(file: string): Promise<string> {

src/packages/fetch-engine/src/downloadZip.ts

@@ -61,7 +61,7 @@ export async function downloadZip(
         }
 
         const lastModified = resp.headers.get('last-modified')!
-        const size = parseFloat(resp.headers.get('content-length'))
+        const size = parseFloat(resp.headers.get('content-length') as string)
         const ws = fs.createWriteStream(partial)
 
         // eslint-disable-next-line @typescript-eslint/no-misused-promises, no-async-promise-executor

src/packages/fetch-engine/src/flatMap.ts

@@ -1,4 +1,5 @@
 function flatten<T>(array: T[]): [] {
+  // @ts-ignore
   return Array.prototype.concat.apply([], array)
 }
 

src/packages/fetch-engine/src/getLatestTag.ts

@@ -51,7 +51,7 @@ export async function getLatestTag(): Promise<any> {
 }
 
 export function getAllUrls(branch: string, commit: string): string[] {
-  const urls = []
+  const urls: string[] = []
   const excludedPlatforms = [
     'freebsd',
     'arm',
@@ -96,7 +96,7 @@ export function getAllUrls(branch: string, commit: string): string[] {
 async function getFirstFinishedCommit(
   branch: string,
   commits: string[],
-): Promise<string> {
+): Promise<string | void> {
   for (const commit of commits) {
     const urls = getAllUrls(branch, commit)
     // TODO: potential to speed things up

src/packages/fetch-engine/src/util.ts

@@ -8,7 +8,7 @@ const debug = Debug('cache-dir')
 
 export async function getRootCacheDir(): Promise<string | null> {
   if (os.platform() === 'win32') {
-    const cacheDir = await findCacheDir({ name: 'prisma', create: true })
+    const cacheDir = findCacheDir({ name: 'prisma', create: true })
     if (cacheDir) {
       return cacheDir
     }

src/packages/fetch-engine/tsconfig.json

@@ -4,7 +4,7 @@
     "lib": ["esnext"],
     "module": "commonjs",
     "target": "es2018",
-    "strict": false,
+    "strict": true,
     "esModuleInterop": true,
     "sourceMap": true,
     "noImplicitAny": false,

src/packages/get-platform/tsconfig.json

@@ -3,7 +3,7 @@
     "lib": ["esnext"],
     "module": "commonjs",
     "target": "es2018",
-    "strict": false,
+    "strict": true,
     "esModuleInterop": true,
     "sourceMap": true,
     "noImplicitAny": false,

src/packages/tests/src/__tests__/__helpers__/integrationTest.ts

@@ -410,7 +410,7 @@ function makeDatasourceBlock(providerName: string, url: string) {
  * Create Prisma schema enabled features array of strings.
  */
 function renderPreviewFeatures(
-  featureMatrix: Input['prismaClientSettings']['previewFeatures'] | undefined,
+  featureMatrix: PreviewFeature[] | undefined,
 ) {
   if (featureMatrix) {
     return `previewFeatures = [${featureMatrix.map(

src/packages/tests/tsconfig.json

@@ -3,7 +3,7 @@
     "lib": ["esnext"],
     "module": "commonjs",
     "target": "es2018",
-    "strict": false,
+    "strict": true,
     "esModuleInterop": true,
     "sourceMap": true,
     "noImplicitAny": false,