Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@prisma/internals (previously @prisma/sdk) uses deprecated dependencies uuid@3.4.0 via temp-write 4.0.0 #11960

Closed
valerii15298 opened this issue Feb 21, 2022 · 3 comments · Fixed by #20295
Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: dependencies topic: internal topic: sdk
Milestone

Comments

@valerii15298
Copy link

valerii15298 commented Feb 21, 2022

Bug description

@prisma/sdk uses outdated dependency temp-write 4.0.0 which uses deprecated uuid@3.4.0 which is I believe inappropriate to use in modern development. Know version temp-write 5.0.0 is available to use.

@prisma/sdk 3.9.2
  ├─┬ checkpoint-client 1.1.20
  │ └── uuid 8.3.2
  └─┬ temp-write 4.0.0
    └── uuid 3.4.0

How to reproduce

Use pnpm as package manager(at least i used pnpm to detect it)

pnpm init -y
pnpm add @prisma/sdk

and you will see:
WARN  deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

Run pnpm why uuid and you will see:

@prisma/sdk 3.9.2
  ├─┬ checkpoint-client 1.1.20
  │ └── uuid 8.3.2
  └─┬ temp-write 4.0.0
    └── uuid 3.4.0

Expected behavior

No depreciation warning and no use of deprecated packages which have problems.

Prisma information

@prisma/sdk

Environment & setup

Windows 11, pnpm as package manager

Prisma Version

3.9.2

@valerii15298 valerii15298 added the kind/bug A reported bug. label Feb 21, 2022
@millsp millsp added the team/client Issue for team Client. label Feb 23, 2022
maddhruv added a commit to maddhruv/prisma that referenced this issue Mar 16, 2022
@Jolg42

This comment was marked as outdated.

@janpio janpio changed the title @prisma/sdk uses deprecated dependencies @prisma/sdk uses deprecated dependencies uuid@3.4.0 via temp-write 4.0.0 Mar 21, 2022
@millsp millsp added kind/improvement An improvement to existing feature and code. and removed kind/bug A reported bug. bug/2-confirmed Bug has been reproduced and confirmed. labels Mar 25, 2022
@Jolg42 Jolg42 changed the title @prisma/sdk uses deprecated dependencies uuid@3.4.0 via temp-write 4.0.0 @prisma/internals (previously @prisma/sdk) uses deprecated dependencies uuid@3.4.0 via temp-write 4.0.0 Dec 6, 2022
@Ustice
Copy link

Ustice commented Jul 18, 2023

temp-write is still included as a dependency, but it looks like it is no longer used. If so, can it be removed?

@Jolg42 Jolg42 added this to the 5.1.0 milestone Jul 19, 2023
Jolg42 added a commit that referenced this issue Jul 19, 2023
@Jolg42
Copy link
Member

Jolg42 commented Jul 19, 2023

@Ustice Indeed!
I quickly opened a PR for removing it #20295

After that we can close this issue since checkpoint-client@1.1.24 uses uuid@9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: dependencies topic: internal topic: sdk
Projects
None yet
5 participants