Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: [libs/sql-schema-describer/src/mssql.rs:338:30] called Result::unwrap() on an Err value: "Couldn't parse default value: create default dbo.GPS_INT AS 0 " #14208

Closed
tomhoule opened this issue Jul 8, 2022 · 5 comments
Closed

Error: [libs/sql-schema-describer/src/mssql.rs:338:30] called Result::unwrap() on an Err value: "Couldn't parse default value: create default dbo.GPS_INT AS 0 " #14208

tomhoule opened this issue Jul 8, 2022 · 5 comments
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: default topic: error reporting Issues created via Prisma's CLI Crash Reporting topic: sql server Microsoft SQL Server

Comments

@tomhoule
Copy link
Contributor

tomhoule commented Jul 8, 2022

https://prisma-errors.netlify.app/report/14128
@tomhoule tomhoule added bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. kind/bug A reported bug. topic: error reporting Issues created via Prisma's CLI Crash Reporting domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels Jul 8, 2022
@jkomyno
Copy link
Contributor

jkomyno commented Aug 26, 2022

Here's another occurrence in prisma@4.2.1: https://prisma-errors.netlify.app/report/14244

@Jolg42 Jolg42 added the topic: sql server Microsoft SQL Server label Jan 3, 2023
@miguelff
Copy link
Contributor

Do we support CREATE DEFAULT Transact-SQL statements? look that we don't and it might the case that the introspection engine is not ignoring this create statement. Can it be @tomhoule @Jolg42 ? This we might be able to reproduce.

@miguelff miguelff added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. and removed bug/0-unknown Bug is new, does not have information for reproduction or reproduction could not be confirmed. labels Jul 17, 2023
@miguelff
Copy link
Contributor

Some more occurrences:

#15704
#15675

@miguelff miguelff mentioned this issue Jul 17, 2023
Closed
@Jolg42
Copy link
Contributor

Jolg42 commented Jul 18, 2023 •
edited
Loading

I am unsure about CREATE DEFAULT Transact-SQL statements. We could try a reproduction.

I could only find this with a as in the statement:
See https://github.com/search?q=org%3Aprisma+%2FCREATE+DEFAULT+.*+as%2F&type=code

We document that "Shared default values are not supported" in docs:
https://www.prisma.io/docs/concepts/database-connectors/sql-server#shared-default-values-are-not-supported

SQL Server docs
https://learn.microsoft.com/en-us/sql/t-sql/statements/create-default-transact-sql?view=sql-server-ver16

tomhoule added a commit to prisma/prisma-engines that referenced this issue Aug 17, 2023
@tomhoule
se: test reproduction for CREATE DEFAULT introspection on mssql
3369d1f 
We have multiple issues related to crashes with CREATE DEFAULT, but this
one prompted this reproduction: prisma/prisma#14208

We _cannot_ reproduce the crash, and the default is not introspected.
So the bug is not confirmed.
tomhoule added a commit to prisma/prisma-engines that referenced this issue Aug 17, 2023
@tomhoule
se: test reproduction for CREATE DEFAULT introspection on mssql
92ffd63 
We have multiple issues related to crashes with CREATE DEFAULT, but this
one prompted this reproduction: prisma/prisma#14208

We _cannot_ reproduce the crash, and the default is not introspected.
So the bug is not confirmed.
@tomhoule tomhoule mentioned this issue Aug 17, 2023
Merged
@tomhoule
Copy link
Contributor Author

There's an introspection test with a CREATE DEFAULT in prisma/prisma-engines#4147 — I can't reproduce the crash. I'll put that in the "I don't know" column.

@tomhoule tomhoule closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
tomhoule added a commit to prisma/prisma-engines that referenced this issue Aug 21, 2023
@tomhoule
se: test reproduction for CREATE DEFAULT introspection on mssql (#4147)
2804dc9 
We have multiple issues related to crashes with CREATE DEFAULT, but this
one prompted this reproduction: prisma/prisma#14208

We _cannot_ reproduce the crash, and the default is not introspected.
So the bug is not confirmed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. topic: default topic: error reporting Issues created via Prisma's CLI Crash Reporting topic: sql server Microsoft SQL Server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miguelff @Jolg42 @jkomyno @tomhoule