Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Please create an issue ... in MigrateEngine.ts #17268

Closed
jkomyno opened this issue Jan 12, 2023 · 2 comments · Fixed by #18162
Closed

Remove Please create an issue ... in MigrateEngine.ts #17268

jkomyno opened this issue Jan 12, 2023 · 2 comments · Fixed by #18162
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: error reporting Issues created via Prisma's CLI Crash Reporting
Milestone
4.14.0

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Jan 12, 2023

Do we still want the "Please create an issue ..." part? That's supposedly already handled in cli/bin.ts when a panic occurs.
@jkomyno jkomyno added kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. labels Jan 12, 2023
@janpio
Copy link
Member

janpio commented Jan 13, 2023

Is it triggered twice now?
One we probably want to keep around.

@jkomyno
Copy link
Contributor Author

jkomyno commented Feb 27, 2023 •
edited

Example output:

Screenshot 2023-02-28 at 00 43 42

Clearly this part is redundant:


Please create an issue with your `schema.prisma` at
https://github.com/prisma/prisma/issues/new

@janpio janpio added the topic: error reporting Issues created via Prisma's CLI Crash Reporting label Feb 27, 2023
jkomyno added a commit that referenced this issue Mar 1, 2023
@jkomyno
feat(migrate): close #17268
c328c30
@jkomyno jkomyno mentioned this issue Mar 1, 2023
Merged
@janpio janpio added this to the 4.14.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: error reporting Issues created via Prisma's CLI Crash Reporting
Projects
None yet
Milestone
4.14.0
2 participants
@janpio @jkomyno