Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introspection warnings: move rendering from DbPull.ts to the engine #17582

Closed
Jolg42 opened this issue Jan 27, 2023 · 1 comment
Closed

Introspection warnings: move rendering from DbPull.ts to the engine #17582

Jolg42 opened this issue Jan 27, 2023 · 1 comment
Assignees
@Jolg42 @jkomyno
Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: introspection topic: introspection-warning topic: tests
Milestone
4.14.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Jan 27, 2023 •
edited

"A long time ago" we decided to create introspection warnings in the engine and handle the rendering in the CLI.

We might want to change that, because:

Related Notion doc: https://www.notion.so/prismaio/CLI-warnings-and-more-specifically-Introspection-warnings-dd5cb5807d8d4b01b2892d9af1724101
@Jolg42 Jolg42 changed the title Introspection: move rendering from DbPull.ts to the engine Introspection warnings: move rendering from DbPull.ts to the engine Jan 27, 2023
@pimeys pimeys added this to the 4.14.0 milestone Apr 20, 2023
@pimeys pimeys mentioned this issue Apr 20, 2023
Merged
@Jolg42 Jolg42 mentioned this issue Apr 25, 2023
Merged
@Jolg42 Jolg42 closed this as completed Apr 27, 2023
@Jolg42
Copy link
Member Author

Jolg42 commented Apr 27, 2023

Note: prisma/prisma-engines#3924 is part of this effort

Jolg42 added a commit that referenced this issue May 12, 2023
@Jolg42
test(db pull): remove duplicated tests
2170b52 
Note that tests are much faster since the split, local run:
```
Test Suites: 10 passed, 10 total
Tests:       1 skipped, 82 passed, 83 total
Snapshots:   470 passed, 470 total
Time:        26.46 s
```

Since #17582 we do not need to test the rendering of the introspection warnings in the CLI, since they are already tested in prisma-engines.
We only need an integration test.

Removed tests were added in prisma-engines from the following PRs:
prisma/prisma-engines#3622
prisma/prisma-engines#3657
prisma/prisma-engines#3849
prisma/prisma-engines#3859
prisma/prisma-engines#3871
prisma/prisma-engines#3877
prisma/prisma-engines#3873
This was referenced May 12, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

@jkomyno jkomyno

Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: introspection topic: introspection-warning topic: tests
Projects
None yet
Milestone
4.14.0
Development

No branches or pull requests
4 participants
@pimeys @janpio @Jolg42 @jkomyno