Query-related spans outside of prisma:engine:itx_runner are disconnected from the tree
#21402
Labels
bug/2-confirmed
Bug has been reproduced and confirmed.
kind/bug
A reported bug.
team/client
Issue for team Client.
tech/engines
Issue for tech Engines.
topic: tracing
Comments
aqrln
added
bug/1-unconfirmed
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Oct 6, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
This was referenced Oct 6, 2023
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Oct 9, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Oct 18, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Oct 25, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Nov 24, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Nov 28, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Dec 10, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Dec 20, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Dec 20, 2023
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Jan 11, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Jan 12, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Jan 18, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added
bug/2-confirmed
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Feb 5, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Feb 14, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
aqrln
added a commit
to prisma/prisma-engines
that referenced
this issue
Apr 9, 2024
Prevent `prisma:engine:response_json_serialization` span from being orphan when using interactive transactions. This check made sense in the past in principle when there were no child spans outside of the iTX runner, and the `prisma:engine` span didn't cover the whole `Engine::query` method duration, but now it makes more sense to always create it. Fixes: prisma/prisma#21402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When using interactive transactions, query-related spans that are not children of
prisma:engine:itx_runner(for now onlyprisma:engine:response_json_serializationbut more may be added in the future) are disconnected from the tree.These
prisma:engine:response_json_serializationon the screenshots below should be somewhere in theprisma:client:transactiontree, probably as children ofprisma:client:operationsince response JSON serialization happens outside of the iTX runner task.The text was updated successfully, but these errors were encountered: